From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: BALATON Zoltan <balaton@eik.bme.hu>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Cc: Richard Henderson <richard.henderson@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] include/exec/cpu-common.h: Rename PAGE_BITS macro to PAGE_RWX
Date: Mon, 6 May 2024 09:26:50 +0200 [thread overview]
Message-ID: <c9eb8dda-b716-4409-965d-4d43edfb29d5@linaro.org> (raw)
In-Reply-To: <20240505121008.44A0D4E602D@zero.eik.bme.hu>
On 5/5/24 14:10, BALATON Zoltan wrote:
> This macro can be used to abbreviate PAGE_READ | PAGE_WRITE | PAGE_EXEC
> for which PAGE_RWX is a better name and renaming it also shows it is
> not related to TARGET_PAGE_BITS.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> accel/tcg/user-exec.c | 2 +-
> bsd-user/mmap.c | 6 +++---
> include/exec/cpu-common.h | 2 +-
> linux-user/elfload.c | 2 +-
> linux-user/mmap.c | 2 +-
> target/cris/mmu.c | 4 ++--
> target/microblaze/helper.c | 2 +-
> 7 files changed, 10 insertions(+), 10 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
and patch queued, thanks!
prev parent reply other threads:[~2024-05-06 7:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-05 12:10 [PATCH] include/exec/cpu-common.h: Rename PAGE_BITS macro to PAGE_RWX BALATON Zoltan
2024-05-05 17:28 ` Richard Henderson
2024-05-06 7:26 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9eb8dda-b716-4409-965d-4d43edfb29d5@linaro.org \
--to=philmd@linaro.org \
--cc=balaton@eik.bme.hu \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).