From: Thomas Huth <thuth@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org
Subject: Re: [PATCH] gitlab: Rename ubuntu-22.04-s390x-all to *-system
Date: Tue, 7 May 2024 08:05:18 +0200 [thread overview]
Message-ID: <ddfdd6c4-9d64-4430-9a2a-099503b51980@redhat.com> (raw)
In-Reply-To: <20240506202341.422814-1-richard.henderson@linaro.org>
On 06/05/2024 22.23, Richard Henderson wrote:
> We already build the linux-user binaries with
> ubuntu-22.04-s390x-all-linux, so there's no need to do it again.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> .gitlab-ci.d/custom-runners/ubuntu-22.04-s390x.yml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/.gitlab-ci.d/custom-runners/ubuntu-22.04-s390x.yml b/.gitlab-ci.d/custom-runners/ubuntu-22.04-s390x.yml
> index 3a2b1e1d24..c3f16d77bb 100644
> --- a/.gitlab-ci.d/custom-runners/ubuntu-22.04-s390x.yml
> +++ b/.gitlab-ci.d/custom-runners/ubuntu-22.04-s390x.yml
> @@ -21,7 +21,7 @@ ubuntu-22.04-s390x-all-linux:
> - make --output-sync check-tcg
> - make --output-sync -j`nproc` check
>
> -ubuntu-22.04-s390x-all:
> +ubuntu-22.04-s390x-all-system:
> extends: .custom_runner_template
> needs: []
> stage: build
> @@ -35,7 +35,7 @@ ubuntu-22.04-s390x-all:
> script:
> - mkdir build
> - cd build
> - - ../configure --disable-libssh
> + - ../configure --disable-libssh --disable-user
While you're at it, you could also drop the --disable-libssh now (it was a
work-around for a bug in Ubuntu 18.04 IIRC).
Reviewed-by: Thomas Huth <thuth@redhat.com>
prev parent reply other threads:[~2024-05-07 6:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 20:23 [PATCH] gitlab: Rename ubuntu-22.04-s390x-all to *-system Richard Henderson
2024-05-06 22:02 ` Philippe Mathieu-Daudé
2024-05-07 6:05 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddfdd6c4-9d64-4430-9a2a-099503b51980@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).