From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>
Cc: Laurent Vivier <laurent@vivier.eu>,
Kyle Evans <kevans@freebsd.org>,
Ilya Leoshkevich <iii@linux.ibm.com>,
Warner Losh <imp@bsdimp.com>, Riku Voipio <riku.voipio@iki.fi>
Subject: Re: [PATCH v2 1/4] accel/tcg: Move system emulation files under sysemu/ subdirectory
Date: Fri, 3 May 2024 14:30:47 +0200 [thread overview]
Message-ID: <f616fcef-efd9-40f2-a2bb-916ef2f17174@linaro.org> (raw)
In-Reply-To: <20240503122526.28312-2-philmd@linaro.org>
On 3/5/24 14:25, Philippe Mathieu-Daudé wrote:
> Some files are specific to system emulation. Move them under
> their own sysemu/ directory. This might help to notice what
> is affected (user, system or both) when doing global refactors.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> accel/tcg/{ => sysemu}/tcg-accel-ops-icount.h | 0
> accel/tcg/{ => sysemu}/tcg-accel-ops-mttcg.h | 0
> accel/tcg/{ => sysemu}/tcg-accel-ops-rr.h | 0
> accel/tcg/{ => sysemu}/tcg-accel-ops.h | 0
> accel/tcg/{ => sysemu}/icount-common.c | 0
> accel/tcg/{ => sysemu}/monitor.c | 4 ++--
> accel/tcg/{ => sysemu}/tcg-accel-ops-icount.c | 0
> accel/tcg/{ => sysemu}/tcg-accel-ops-mttcg.c | 0
> accel/tcg/{ => sysemu}/tcg-accel-ops-rr.c | 0
> accel/tcg/{ => sysemu}/tcg-accel-ops.c | 0
> accel/tcg/meson.build | 14 ++------------
> accel/tcg/sysemu/meson.build | 11 +++++++++++
> 12 files changed, 15 insertions(+), 14 deletions(-)
> rename accel/tcg/{ => sysemu}/tcg-accel-ops-icount.h (100%)
> rename accel/tcg/{ => sysemu}/tcg-accel-ops-mttcg.h (100%)
> rename accel/tcg/{ => sysemu}/tcg-accel-ops-rr.h (100%)
> rename accel/tcg/{ => sysemu}/tcg-accel-ops.h (100%)
> rename accel/tcg/{ => sysemu}/icount-common.c (100%)
> rename accel/tcg/{ => sysemu}/monitor.c (99%)
> rename accel/tcg/{ => sysemu}/tcg-accel-ops-icount.c (100%)
> rename accel/tcg/{ => sysemu}/tcg-accel-ops-mttcg.c (100%)
> rename accel/tcg/{ => sysemu}/tcg-accel-ops-rr.c (100%)
> rename accel/tcg/{ => sysemu}/tcg-accel-ops.c (100%)
> create mode 100644 accel/tcg/sysemu/meson.build
> diff --git a/accel/tcg/meson.build b/accel/tcg/meson.build
> index aef80de967..1b91f26a7f 100644
> --- a/accel/tcg/meson.build
> +++ b/accel/tcg/meson.build
> @@ -18,19 +18,9 @@ if get_option('plugins')
> endif
> specific_ss.add_all(when: 'CONFIG_TCG', if_true: tcg_specific_ss)
>
> -specific_ss.add(when: ['CONFIG_SYSTEM_ONLY', 'CONFIG_TCG'], if_true: files(
> +specific_ss.add(when: ['CONFIG_SYSTEM_ONLY', 'CONFIG_TCG'], if_true: files( # SoftMMU
> 'cputlb.c',
> 'watchpoint.c',
> ))
>
> -system_ss.add(when: ['CONFIG_TCG'], if_true: files(
> - 'icount-common.c',
> - 'monitor.c',
> -))
> -
> -tcg_module_ss.add(when: ['CONFIG_SYSTEM_ONLY', 'CONFIG_TCG'], if_true: files(
> - 'tcg-accel-ops.c',
> - 'tcg-accel-ops-mttcg.c',
> - 'tcg-accel-ops-icount.c',
> - 'tcg-accel-ops-rr.c',
> -))
> +subdir('sysemu')
> diff --git a/accel/tcg/sysemu/meson.build b/accel/tcg/sysemu/meson.build
> new file mode 100644
> index 0000000000..d0b4939ba9
> --- /dev/null
> +++ b/accel/tcg/sysemu/meson.build
> @@ -0,0 +1,11 @@
> +system_ss.add(files(
Oops, broken rebase, sorry...
> + 'icount-common.c',
> + 'monitor.c',
> +))
> +
> +tcg_module_ss.add(when: ['CONFIG_SYSTEM_ONLY'], if_true: files(
> + 'tcg-accel-ops.c',
> + 'tcg-accel-ops-mttcg.c',
> + 'tcg-accel-ops-icount.c',
> + 'tcg-accel-ops-rr.c',
> +))
next prev parent reply other threads:[~2024-05-03 12:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 12:25 [PATCH v2 0/4] accel/tcg: Call tcg_flush_jmp_cache() again when creating user-mode cpu Philippe Mathieu-Daudé
2024-05-03 12:25 ` [PATCH v2 1/4] accel/tcg: Move system emulation files under sysemu/ subdirectory Philippe Mathieu-Daudé
2024-05-03 12:30 ` Philippe Mathieu-Daudé [this message]
2024-05-03 12:25 ` [PATCH v2 2/4] accel/tcg: Do not define cpu_exec_reset_hold() as stub Philippe Mathieu-Daudé
2024-05-03 12:25 ` [PATCH v2 3/4] accel/tcg: Introduce common tcg_exec_cpu_reset_hold() method Philippe Mathieu-Daudé
2024-05-03 12:25 ` [PATCH v2 4/4] accel/tcg: Always call tcg_flush_jmp_cache() on reset Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f616fcef-efd9-40f2-a2bb-916ef2f17174@linaro.org \
--to=philmd@linaro.org \
--cc=iii@linux.ibm.com \
--cc=imp@bsdimp.com \
--cc=kevans@freebsd.org \
--cc=laurent@vivier.eu \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).