From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>, radiotap@NetBSD.org
Subject: Re: EHT NSS units question
Date: Wed, 24 Jul 2024 06:45:47 -0700 [thread overview]
Message-ID: <71d4c465-f709-4866-bc11-eb9c10e6bc80@candelatech.com> (raw)
In-Reply-To: <1fff21828808ad4f092524a405dea4f5c4cff10d.camel@sipsolutions.net>
On 7/24/24 03:58, Johannes Berg wrote:
> On Thu, 2024-07-18 at 06:58 -0700, Ben Greear wrote:
>> Hello,
>>
>> I would like to know if the units for NSS for EHT user element
>> are zero based (ie, 0x0 means 1NSS) or ones-based (0x1 means 1NSS).
>>
>> From what I can tell, wireshark is using zero based counting, but
>> mt76 driver is using ones-based counting when filling in the radiotap header.
>>
>> I am not sure which one to fix...
>>
>
> Looks like we never fully defined this ... Arguably having 4 bits means
> that we intended to have 1-8 (and perhaps 0 mean "unknown"), but having
> another bit for "I knew the NSS" kind of made that unnecessary ...
>
> But since both wireshark and iwlwifi agree to have 0=1NSS and 1=2NSS I
> guess it's better to clarify that in the spec and fix mt76.
Ok thanks, I have a small patch that fixes mt76, will clean it up and post
to the wifi mailing list.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
prev parent reply other threads:[~2024-07-24 13:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-18 13:58 EHT NSS units question Ben Greear
2024-07-24 10:58 ` Johannes Berg
2024-07-24 13:45 ` Ben Greear [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71d4c465-f709-4866-bc11-eb9c10e6bc80@candelatech.com \
--to=greearb@candelatech.com \
--cc=johannes@sipsolutions.net \
--cc=radiotap@NetBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).