From: Richard Sharpe <realrichardsharpe-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Krishna Chaitanya
<chaitanya.mgit-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: radiotap-sUITvd46vNxg9hUCZPvPmw@public.gmane.org
Subject: Re: DMG Support
Date: Thu, 27 Jun 2019 13:40:36 -0700 [thread overview]
Message-ID: <CACyXjPzNkK6Uq5kbA8O2e_4szD7T9r6DifkLCQ5ks1h1e4sAPg@mail.gmail.com> (raw)
In-Reply-To: <CABPxzYJyabjkEx5SwF_iED8=vBcUxFj7WtHYG=n8ssAb6u5O_g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Thu, Jun 27, 2019 at 12:56 PM Krishna Chaitanya
<chaitanya.mgit-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>
> On Thu, Jun 27, 2019 at 11:46 PM Richard Sharpe
> <realrichardsharpe-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> >
> > On Thu, Jun 27, 2019 at 10:16 AM Krishna Chaitanya
> > <chaitanya.mgit-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> > >
> > > Hi Guys,
> > >
> > > I am looking at support for DMG specific fields to radiotap, the only
> > > discussion I have found didn't reach any conclusion [1].
> > >
> > > Is there a plan to support these fields? It definitely needs a DMG
> > > Type field with at least below params (from top of my head)
> > >
> > > - MCS (and extended MCS) along with data rate mapping
> > > - C-PHY
> > > - SC-PHY
> > > - Low power SC-PHY
> > > -OFDM
> > > - Beam/Sector/Antenna ID Information
> > > - RCPI
> >
> > Is there any kernel capture code or any other device that would support this?
> Yes, https://elixir.bootlin.com/linux/latest/source/drivers/net/wireless/ath/wil6210/txrx.c#L317.
> (Only upstream DMG driver) But, it has minimal info due to lack of DMG
> specific fields.
> Although, I am not sure whether it supports other PHY info than MCS and RSSI.
> We could query beams, but beam info is not present in rx_desc.
>
> > The general procedure to get there, however, is:
> >
> > 1. Propose the new header.
> > 2. Implement code in Wireshark to handle the header and include useful
> > info in the pseudo-header
> > 3. Implement code that can generate sample captures with the new header.
> > 4. Get someone to add such DMG support to DMG-capable devices to
> > generate the new header.
>
> Yes, that's the norm. Before proposing the fields, just wanted to
> check if there is an ongoing work or
> some kind of decision. So, should I go ahead and propose those fields?
I would say yes. Take note that any new headers should use the new TLV format.
Also, there has been a proposal for an S1G header so you might want to
use the next available type.
--
Regards,
Richard Sharpe
(何以解憂？唯有杜康。--曹操)(传说杜康是酒的发明者)
next prev parent reply other threads:[~2019-06-27 20:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 17:15 DMG Support Krishna Chaitanya
[not found] ` <CABPxzYLh=fcGFFAMxcNY9pFN8HOczgoPcYe_+NNMiW-uuRDe5Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-06-27 18:14 ` Richard Sharpe
[not found] ` <CACyXjPz5YD9VUcmbtO68nexEbjpaQOeZnLixs078c3FvW2B7eA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-06-27 19:56 ` Krishna Chaitanya
[not found] ` <CABPxzYJyabjkEx5SwF_iED8=vBcUxFj7WtHYG=n8ssAb6u5O_g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-06-27 20:40 ` Richard Sharpe [this message]
[not found] ` <CACyXjPzNkK6Uq5kbA8O2e_4szD7T9r6DifkLCQ5ks1h1e4sAPg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-06-28 8:02 ` Krishna Chaitanya
[not found] ` <CABPxzYKAc=J6x0UcC4TpSvgfuymyWS4N8bwCnA_dnDdS1rdgAw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-06-28 8:24 ` Johannes Berg
[not found] ` <dfef0682ee1af5e92ccc6551f888b0118fcdd2f4.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2019-06-28 9:55 ` Krishna Chaitanya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACyXjPzNkK6Uq5kbA8O2e_4szD7T9r6DifkLCQ5ks1h1e4sAPg@mail.gmail.com \
--to=realrichardsharpe-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=chaitanya.mgit-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=radiotap-sUITvd46vNxg9hUCZPvPmw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).