From: Johannes Berg <johannes@sipsolutions.net>
To: Richard Sharpe <realrichardsharpe@gmail.com>,
radiotap@radiotap.org, Ray Wang <rwang@wi-fi.org>,
Aaron Lee <jehun.lee@newracom.com>, Tasheng Lin <tlin@wi-fi.org>
Subject: Re: A modified, and maybe final, proposal for an S1G header for RadioTap
Date: Tue, 02 Feb 2021 21:59:57 +0100 [thread overview]
Message-ID: <e1a3173d370aa96d004359f9e7061e89ee478165.camel@sipsolutions.net> (raw)
In-Reply-To: <CACyXjPx40--VvxKhxbM1tekOcoXtpt-Cu7_KCPTk_+khfkQkHw@mail.gmail.com>
Hi Richard,
Couple of (last-minute!) comments ...
> Structure
> : u16 known, u16 data1, u16 data2, u8 ndp_type, u8[5] ndp_data;
>
> Required Alignment
> : 4
If you only have u16 data, what's the value of 4-byte alignment?
> Is NDP indicates that this is an NDP frame, however, the content might
> not be known.
Should that have a note that the zero-length PSDU field should be set?
But if so, should that get a new sub-type for S1G NDP?
Otherwise:
> > **`0x0080`** | Is NDP, which means no packet data follows this header! |
this overlaps?
I guess it doesn't really matter though if that overlaps.
> > **`0x00C0`** | Number spatial streams: 0=1 Spatial stream, 1=2, ..
> 3=4 Spatial streams |
"Number of" I guess
johannes
next prev parent reply other threads:[~2021-02-02 21:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-14 15:57 A modified, and maybe final, proposal for an S1G header for RadioTap Richard Sharpe
2021-02-01 15:00 ` Richard Sharpe
2021-02-02 20:59 ` Johannes Berg [this message]
2021-02-04 17:57 ` Richard Sharpe
2021-12-06 20:10 ` Johannes Berg
2021-12-06 22:12 ` Aaron - Jehun Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1a3173d370aa96d004359f9e7061e89ee478165.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=jehun.lee@newracom.com \
--cc=radiotap@radiotap.org \
--cc=realrichardsharpe@gmail.com \
--cc=rwang@wi-fi.org \
--cc=tlin@wi-fi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).