From: Stefan Wiehler <stefan.wiehler@nokia.com>
To: Russell King <linux@armlinux.org.uk>,
"Paul E. McKenney" <paulmck@kernel.org>,
Joel Fernandes <joel@joelfernandes.org>,
Josh Triplett <josh@joshtriplett.org>,
Boqun Feng <boqun.feng@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Zqiang <qiang.zhang1211@gmail.com>,
linux-arm-kernel@lists.infradead.org, rcu@vger.kernel.org,
linux-kernel@vger.kernel.org,
Stefan Wiehler <stefan.wiehler@nokia.com>
Subject: [PATCH] arm: smp: Avoid false positive CPU hotplug Lockdep-RCU splat
Date: Thu, 7 Mar 2024 17:09:51 +0100 [thread overview]
Message-ID: <20240307160951.3607374-1-stefan.wiehler@nokia.com> (raw)
With CONFIG_PROVE_RCU_LIST=y and by executing
$ echo 0 > /sys/devices/system/cpu/cpu1/online
one can trigger the following Lockdep-RCU splat on ARM:
=============================
WARNING: suspicious RCU usage
6.8.0-rc7-00001-g0db1d0ed8958 #10 Not tainted
-----------------------------
kernel/locking/lockdep.c:3762 RCU-list traversed in non-reader section!!
other info that might help us debug this:
RCU used illegally from offline CPU!
rcu_scheduler_active = 2, debug_locks = 1
no locks held by swapper/1/0.
stack backtrace:
CPU: 1 PID: 0 Comm: swapper/1 Not tainted 6.8.0-rc7-00001-g0db1d0ed8958 #10
Hardware name: Allwinner sun8i Family
unwind_backtrace from show_stack+0x10/0x14
show_stack from dump_stack_lvl+0x60/0x90
dump_stack_lvl from lockdep_rcu_suspicious+0x150/0x1a0
lockdep_rcu_suspicious from __lock_acquire+0x11fc/0x29f8
__lock_acquire from lock_acquire+0x10c/0x348
lock_acquire from _raw_spin_lock_irqsave+0x50/0x6c
_raw_spin_lock_irqsave from check_and_switch_context+0x7c/0x4a8
check_and_switch_context from arch_cpu_idle_dead+0x10/0x7c
arch_cpu_idle_dead from do_idle+0xbc/0x138
do_idle from cpu_startup_entry+0x28/0x2c
cpu_startup_entry from secondary_start_kernel+0x11c/0x124
secondary_start_kernel from 0x401018a0
The CPU is already reported as offline from RCU perspective in
cpuhp_report_idle_dead() before arch_cpu_idle_dead() is invoked. Above
RCU-Lockdep splat is then triggered by check_and_switch_context() acquiring the
ASID spinlock.
Avoid the false-positive Lockdep-RCU splat by briefly reporting the CPU as
online again while the spinlock is held.
Signed-off-by: Stefan Wiehler <stefan.wiehler@nokia.com>
---
arch/arm/kernel/smp.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c
index 3431c0553f45..6875e2c5dd50 100644
--- a/arch/arm/kernel/smp.c
+++ b/arch/arm/kernel/smp.c
@@ -319,7 +319,14 @@ void __noreturn arch_cpu_idle_dead(void)
{
unsigned int cpu = smp_processor_id();
+ /*
+ * Briefly report CPU as online again to avoid false positive
+ * Lockdep-RCU splat when check_and_switch_context() acquires ASID
+ * spinlock.
+ */
+ rcutree_report_cpu_starting(cpu);
idle_task_exit();
+ rcutree_report_cpu_dead();
local_irq_disable();
--
2.42.0
next reply other threads:[~2024-03-07 16:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 16:09 Stefan Wiehler [this message]
2024-03-07 17:45 ` [PATCH] arm: smp: Avoid false positive CPU hotplug Lockdep-RCU splat Paul E. McKenney
2024-03-07 17:49 ` Paul E. McKenney
2024-03-07 18:54 ` Russell King (Oracle)
2024-03-07 19:08 ` Paul E. McKenney
2024-03-07 18:49 ` Boqun Feng
2024-03-08 10:20 ` Stefan Wiehler
2024-03-08 14:57 ` Joel Fernandes
2024-03-09 7:45 ` Stefan Wiehler
2024-03-09 9:57 ` Russell King (Oracle)
2024-03-12 22:14 ` Will Deacon
2024-03-12 22:39 ` Russell King (Oracle)
2024-03-13 0:32 ` Will Deacon
2024-03-13 9:58 ` Russell King (Oracle)
2024-03-11 16:08 ` Russell King (Oracle)
2024-03-11 16:17 ` Stefan Wiehler
2024-03-11 19:01 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240307160951.3607374-1-stefan.wiehler@nokia.com \
--to=stefan.wiehler@nokia.com \
--cc=boqun.feng@gmail.com \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@kernel.org \
--cc=qiang.zhang1211@gmail.com \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).