From: "Paul E. McKenney" <paulmck@kernel.org>
To: Zqiang <qiang.zhang1211@gmail.com>
Cc: frederic@kernel.org, neeraj.upadhyay@kernel.org,
joel@joelfernandes.org, linux-kernel@vger.kernel.org,
rcu@vger.kernel.org
Subject: Re: [PATCH] rcutorture: Use the gp_kthread_dbg operation specified by cur_ops
Date: Sat, 16 Mar 2024 22:03:51 -0700 [thread overview]
Message-ID: <36f02d85-77bb-42a3-aa31-f7d3ac57aad6@paulmck-laptop> (raw)
In-Reply-To: <20240315071710.8575-1-qiang.zhang1211@gmail.com>
On Fri, Mar 15, 2024 at 03:17:10PM +0800, Zqiang wrote:
> Currently, for different types of rcutorture tests, when dumping
> gp_kthread because of slow gp, always invoke show_rcu_gp_kthreads().
> this commit therefore changes show_rcu_gp_kthreads() to
> cur_ops->gp_kthread_dbg() to dump the correct information in
> rcu_torture_writer().
>
> Signed-off-by: Zqiang <qiang.zhang1211@gmail.com>
Good eyes, queued, thank you!
Thanx, Paul
> ---
> kernel/rcu/rcutorture.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
> index 51eebc523f08..9d269682256a 100644
> --- a/kernel/rcu/rcutorture.c
> +++ b/kernel/rcu/rcutorture.c
> @@ -1617,7 +1617,8 @@ rcu_torture_writer(void *arg)
> if (list_empty(&rcu_tortures[i].rtort_free) &&
> rcu_access_pointer(rcu_torture_current) != &rcu_tortures[i]) {
> tracing_off();
> - show_rcu_gp_kthreads();
> + if (cur_ops->gp_kthread_dbg)
> + cur_ops->gp_kthread_dbg();
> WARN(1, "%s: rtort_pipe_count: %d\n", __func__, rcu_tortures[i].rtort_pipe_count);
> rcu_ftrace_dump(DUMP_ALL);
> }
> --
> 2.17.1
>
prev parent reply other threads:[~2024-03-17 5:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 7:17 [PATCH] rcutorture: Use the gp_kthread_dbg operation specified by cur_ops Zqiang
2024-03-17 5:03 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36f02d85-77bb-42a3-aa31-f7d3ac57aad6@paulmck-laptop \
--to=paulmck@kernel.org \
--cc=frederic@kernel.org \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neeraj.upadhyay@kernel.org \
--cc=qiang.zhang1211@gmail.com \
--cc=rcu@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).