SELinux-Refpolicy Archive mirror
 help / color / mirror / Atom feed
From: Chris PeBenito <pebenito@ieee.org>
To: Russell Coker <russell@coker.com.au>, selinux-refpolicy@vger.kernel.org
Subject: Re: [PATCH] misc kernel and system patches with Dominick's changes
Date: Thu, 28 Jan 2021 11:18:11 -0500	[thread overview]
Message-ID: <fcf9ccd3-d31b-0597-5daa-75a4647a8435@ieee.org> (raw)
In-Reply-To: <YBEANDbm26zwQ9aj@xev>

On 1/27/21 12:55 AM, Russell Coker wrote:
> This patch has the changes that Dominick suggested and the things that
> needed more discussion removed.  I think it's ready to merge.
> 
> 
> Signed-off-by: Russell Coker <russell@coker.com.au>


> @@ -967,8 +987,14 @@ tunable_policy(`systemd_nspawn_labeled_n
>   	# manage etc symlinks for /etc/localtime
>   	files_manage_etc_symlinks(systemd_nspawn_t)
>   	files_mounton_runtime_dirs(systemd_nspawn_t)
> +	files_mounton_kernel_symbol_table(systemd_nspawn_t)
>   	files_search_home(systemd_nspawn_t)
[...]
> @@ -986,6 +1012,7 @@ tunable_policy(`systemd_nspawn_labeled_n
>   	selinux_getattr_fs(systemd_nspawn_t)
>   	selinux_remount_fs(systemd_nspawn_t)
>   	selinux_search_fs(systemd_nspawn_t)
> +	selinux_mounton_fs(systemd_nspawn_t)
>   
>   	init_domtrans(systemd_nspawn_t)
>   

I think I'm ok with the other rules, but this makes me think.  We already have 
several mount points that nspawn is using and it seems like a slippery slope. 
While conceivably you could make nspawn mount anywhere, maybe this is a 
candidate for mounting on all init_mountpoint_type ?

-- 
Chris PeBenito

      reply	other threads:[~2021-01-28 16:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-27  5:55 [PATCH] misc kernel and system patches with Dominick's changes Russell Coker
2021-01-28 16:18 ` Chris PeBenito [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fcf9ccd3-d31b-0597-5daa-75a4647a8435@ieee.org \
    --to=pebenito@ieee.org \
    --cc=russell@coker.com.au \
    --cc=selinux-refpolicy@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).