smatch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Murray <andrew.murray@arm.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: smatch@vger.kernel.org
Subject: Re: [PATCH] db/smdb: add info command with type filtering
Date: Fri, 21 Jun 2019 15:59:31 +0100	[thread overview]
Message-ID: <20190621145931.GK20984@e119886-lin.cambridge.arm.com> (raw)
In-Reply-To: <20190621145302.GS28859@kadam>

On Fri, Jun 21, 2019 at 05:53:02PM +0300, Dan Carpenter wrote:
> On Fri, Jun 21, 2019 at 11:18:42AM +0100, Andrew Murray wrote:
> > @@ -612,13 +619,6 @@ elif sys.argv[1] == "call_info":
> >      func = sys.argv[3]
> >      caller_info_values(filename, func)
> >      print_caller_info(filename, func)
> > -elif sys.argv[1] == "user_data":
> > -    func = sys.argv[2]
> > -    filename = sys.argv[3]

The patch didn't apply because my local tree had this line ^^ in.

> > -    print_caller_info(filename, func, "USER_DATA")
> > -elif sys.argv[1] == "param_value":
> > -    func = sys.argv[2]
> > -    print_caller_info(filename, func, "PARAM_VALUE")
> >  elif sys.argv[1] == "function_ptr" or sys.argv[1] == "fn_ptr":
> >      func = sys.argv[2]
> >      print_fn_ptrs(func)
> 
> Somehow this chunk didn't apply at all but I did it manually.

I messed up when making the patch.

Thanks,

Andrew Murray

> 
> Applied.
> 
> regards,
> dan carpenter

      reply	other threads:[~2019-06-21 14:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-21 10:18 [PATCH] db/smdb: add info command with type filtering Andrew Murray
2019-06-21 14:53 ` Dan Carpenter
2019-06-21 14:59   ` Andrew Murray [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190621145931.GK20984@e119886-lin.cambridge.arm.com \
    --to=andrew.murray@arm.com \
    --cc=dan.carpenter@oracle.com \
    --cc=smatch@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).