smatch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Harshvardhan Jha <harshvardhan.jha@oracle.com>
Cc: smatch@vger.kernel.org
Subject: Re: [PATCH] extra: Fixed false output of handle_AND_op and handle_AND_condition
Date: Mon, 12 Jul 2021 10:30:06 +0300	[thread overview]
Message-ID: <20210712073006.GA1954@kadam> (raw)
In-Reply-To: <20210710205047.11596-1-harshvardhan.jha@oracle.com>

On Sun, Jul 11, 2021 at 02:20:47AM +0530, Harshvardhan Jha wrote:
> -	set_extra_expr_true_false(var,
> -				  true_rl ? alloc_estate_rl(true_rl) : NULL,
> -				  false_rl ? alloc_estate_rl(false_rl) : NULL);
> +
> +	sval.uvalue = 1ULL << (ffsll(known.uvalue) - 1);
> +	bits_expr = value_expr_sval(sval);
                    ^^^^^^^^^^^^^^^
Ugh.  Actually you forgot to send me this part of the patch so it doesn't
compile.  Please resend.

regards,
dan carpenter

      reply	other threads:[~2021-07-12  7:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-10 20:50 [PATCH] extra: Fixed false output of handle_AND_op and handle_AND_condition Harshvardhan Jha
2021-07-12  7:30 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210712073006.GA1954@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=harshvardhan.jha@oracle.com \
    --cc=smatch@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).