From: Sean Young <sean@mess.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-media@vger.kernel.org, smatch@vger.kernel.org
Subject: Re: [PATCH] media: lirc: suppress false positive smatch warning
Date: Thu, 10 Mar 2022 14:49:50 +0000 [thread overview]
Message-ID: <YioQDufZYul4jl14@gofer.mess.org> (raw)
In-Reply-To: <20220310144230.GI3315@kadam>
On Thu, Mar 10, 2022 at 05:42:30PM +0300, Dan Carpenter wrote:
> On Thu, Mar 10, 2022 at 01:23:50PM +0000, Sean Young wrote:
> > The latest smatch says:
> >
> > drivers/media/rc/lirc_dev.c:632 lirc_read_mode2() error: uninitialized symbol 'copied'.
> > drivers/media/rc/lirc_dev.c:671 lirc_read_scancode() error: uninitialized symbol 'copied'.
> >
> > This is a false positive since in all reaching code paths, copied will
> > be set. Work around this by providing a zero initializer for copied.
> >
> > Cc: Dan Carpenter <dan.carpenter@oracle.com>
> > Cc: smatch@vger.kernel.org
> > Signed-off-by: Sean Young <sean@mess.org>
>
> I'm sorry for this. I can't reproduce this on my system. I just did a
> push for something unrelated and I don't know what the previous HEAD
> was...
You're right, with the latest HEAD the warning goes away. Great, let's drop
this patch then.
Thanks for a great tool
Sean
prev parent reply other threads:[~2022-03-10 14:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 13:23 [PATCH] media: lirc: suppress false positive smatch warning Sean Young
2022-03-10 14:42 ` Dan Carpenter
2022-03-10 14:49 ` Sean Young [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YioQDufZYul4jl14@gofer.mess.org \
--to=sean@mess.org \
--cc=dan.carpenter@oracle.com \
--cc=linux-media@vger.kernel.org \
--cc=smatch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).