From: "Marek Behún" <kabel@kernel.org>
To: Andy Shevchenko <andy@kernel.org>
Cc: "Gregory CLEMENT" <gregory.clement@bootlin.com>,
"Arnd Bergmann" <arnd@arndb.de>,
soc@kernel.org, arm@kernel.org,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Olivia Mackall" <olivia@selenic.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH v7 6/9] platform: cznic: turris-omnia-mcu: Add support for MCU provided TRNG
Date: Thu, 25 Apr 2024 12:41:30 +0200 [thread overview]
Message-ID: <20240425124130.6c96e273@dellmb> (raw)
In-Reply-To: <Zioql5TSzTLtMsX7@smile.fi.intel.com>
On Thu, 25 Apr 2024 13:04:07 +0300
Andy Shevchenko <andy@kernel.org> wrote:
> On Thu, Apr 25, 2024 at 11:34:47AM +0200, Marek Behún wrote:
> > On Wed, 24 Apr 2024 22:47:10 +0300
> > Andy Shevchenko <andy@kernel.org> wrote:
> > > On Wed, Apr 24, 2024 at 08:51:23PM +0200, Marek Behún wrote:
>
> ...
>
> > > For what purpose? I don't see drivers doing that. Are you expecting that
> > > the same IRQ mapping will be reused for something else? Can you elaborate
> > > how? (I can imagine one theoretical / weird case how to achieve that,
> > > but impractical.)
> >
> > I do a lot of binding/unbinding of that driver. I was under the
> > impression that all resources should be dropped on driver unbind.
> >
> > > Besides above, this is asymmetrical call to gpiod_to_irq(). If we really care
> > > about this, it should be provided by GPIO library.
> >
> > Something like the following?
>
> Not needed. IRQ mappings are per domain, and GPIO chip has its own associated
> with the respective lifetime, AFAIU when you remove the GPIO chip, all mappings
> will be disposed (as I pointed out in previous mail).
>
OMG you are right :) of course. OK, I shall drop this.
Marek
next prev parent reply other threads:[~2024-04-25 10:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 17:37 [PATCH v7 0/9] Turris Omnia MCU driver Marek Behún
2024-04-24 17:38 ` [PATCH v7 1/9] dt-bindings: arm: add cznic,turris-omnia-mcu binding Marek Behún
2024-04-24 18:16 ` Rob Herring
2024-04-24 18:22 ` Marek Behún
2024-04-25 17:18 ` Conor Dooley
2024-04-24 17:38 ` [PATCH v7 2/9] platform: cznic: Add preliminary support for Turris Omnia MCU Marek Behún
2024-04-24 17:38 ` [PATCH v7 3/9] platform: cznic: turris-omnia-mcu: Add support for MCU connected GPIOs Marek Behún
2024-04-24 17:38 ` [PATCH v7 4/9] platform: cznic: turris-omnia-mcu: Add support for poweroff and wakeup Marek Behún
2024-04-26 9:41 ` Alexandre Belloni
2024-04-24 17:38 ` [PATCH v7 5/9] platform: cznic: turris-omnia-mcu: Add support for MCU watchdog Marek Behún
2024-04-24 17:38 ` [PATCH v7 6/9] platform: cznic: turris-omnia-mcu: Add support for MCU provided TRNG Marek Behún
2024-04-24 18:33 ` Andy Shevchenko
2024-04-24 18:51 ` Marek Behún
2024-04-24 19:47 ` Andy Shevchenko
2024-04-25 9:34 ` Marek Behún
2024-04-25 10:04 ` Andy Shevchenko
2024-04-25 10:41 ` Marek Behún [this message]
2024-04-25 9:58 ` Andy Shevchenko
2024-04-24 18:35 ` Andy Shevchenko
2024-04-24 17:38 ` [PATCH v7 7/9] platform: cznic: turris-omnia-mcu: Add support for digital message signing via debugfs Marek Behún
2024-04-24 17:38 ` [PATCH v7 8/9] ARM: dts: turris-omnia: Add MCU system-controller node Marek Behún
2024-04-26 16:01 ` Gregory CLEMENT
2024-04-26 16:40 ` Marek Behún
2024-04-26 18:21 ` Andrew Lunn
2024-04-24 17:38 ` [PATCH v7 9/9] ARM: dts: turris-omnia: Add GPIO key node for front button Marek Behún
2024-04-26 16:02 ` Gregory CLEMENT
2024-04-26 16:13 ` [PATCH v7 0/9] Turris Omnia MCU driver Gregory CLEMENT
2024-04-30 11:54 ` Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240425124130.6c96e273@dellmb \
--to=kabel@kernel.org \
--cc=andy@kernel.org \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.clement@bootlin.com \
--cc=hdegoede@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-crypto@vger.kernel.org \
--cc=olivia@selenic.com \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).