From: Kalle Valo <kvalo@kernel.org>
To: Francesco Dolcini <francesco@dolcini.it>
Cc: Brian Norris <briannorris@chromium.org>,
Francesco Dolcini <francesco@dolcini.it>,
Rafael Beims <rafael.beims@toradex.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
tsung-hsien.hsieh@nxp.com, David Lin <yu-hao.lin@nxp.com>,
stable@vger.kernel.org,
Francesco Dolcini <francesco.dolcini@toradex.com>
Subject: Re: [v1] wifi: mwifiex: Fix interface type change
Date: Fri, 17 May 2024 08:04:24 +0000 (UTC) [thread overview]
Message-ID: <171593306296.3274748.4179889716794962474.kvalo@kernel.org> (raw)
In-Reply-To: <20240510110458.15475-1-francesco@dolcini.it>
Francesco Dolcini <francesco@dolcini.it> wrote:
> From: Rafael Beims <rafael.beims@toradex.com>
>
> When changing the interface type we also need to update the bss_num, the
> driver private data is searched based on a unique (bss_type, bss_num)
> tuple, therefore every time bss_type changes, bss_num must also change.
>
> This fixes for example an issue in which, after the mode changed, a
> wireless scan on the changed interface would not finish, leading to
> repeated -EBUSY messages to userspace when other scan requests were
> sent.
>
> Fixes: c606008b7062 ("mwifiex: Properly initialize private structure on interface type changes")
> Cc: stable@vger.kernel.org
> Signed-off-by: Rafael Beims <rafael.beims@toradex.com>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
BTW I removed the Reviewed-by from the commit message, I don't see the need to
have both Reviewed-by and s-o-b.
--
https://patchwork.kernel.org/project/linux-wireless/patch/20240510110458.15475-1-francesco@dolcini.it/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-05-17 8:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 11:04 [PATCH v1] wifi: mwifiex: Fix interface type change Francesco Dolcini
2024-05-17 8:03 ` [v1] " Kalle Valo
2024-05-17 8:04 ` Kalle Valo [this message]
2024-05-17 8:13 ` Francesco Dolcini
2024-05-17 9:32 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171593306296.3274748.4179889716794962474.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=briannorris@chromium.org \
--cc=francesco.dolcini@toradex.com \
--cc=francesco@dolcini.it \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rafael.beims@toradex.com \
--cc=stable@vger.kernel.org \
--cc=tsung-hsien.hsieh@nxp.com \
--cc=yu-hao.lin@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).