* v4.4-rc4 regression with direct-io
@ 2015-12-08 21:39 Ross Zwisler
2015-12-08 21:51 ` Al Viro
0 siblings, 1 reply; 4+ messages in thread
From: Ross Zwisler @ 2015-12-08 21:39 UTC (permalink / raw
To: Jan Kara
Cc: stable, Steven Whitehouse, Avi Kivity, Jens Axboe, linux-fsdevel,
xfs, torvalds
Hey Jan,
In my test setup this commit:
74cedf9b6c60 ("direct-io: Fix negative return from dio read beyond eof")
causes a regression with XFS and the test generic/113. The test used to
pass, but with the above mentioned commit it just hangs indefinitely.
This commit went in between v4.4-rc3 and v4.4-rc4, and it looks like it was
marked for stable?
I've run "echo w > /proc/sysrq-trigger", and it doesn't list any locked
processes so I don't believe that this is a deadlock. It looks like a
livelock?
My test setup is a pair of 4GiB PMEM partitions (one as the test device and
one as the scratch) in a qemu virtual machine. This test did not involve DAX,
and turning DAX on makes the test pass once again.
Please let me know if you need any more info or have trouble reproducing the
issue. I'm happy to test patches.
Thanks,
- Ross
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: v4.4-rc4 regression with direct-io
2015-12-08 21:39 v4.4-rc4 regression with direct-io Ross Zwisler
@ 2015-12-08 21:51 ` Al Viro
2015-12-08 23:14 ` Ross Zwisler
2015-12-09 11:49 ` Jan Kara
0 siblings, 2 replies; 4+ messages in thread
From: Al Viro @ 2015-12-08 21:51 UTC (permalink / raw
To: Ross Zwisler, Jan Kara, stable, Steven Whitehouse, Avi Kivity,
Jens Axboe, linux-fsdevel, xfs, torvalds
On Tue, Dec 08, 2015 at 02:39:02PM -0700, Ross Zwisler wrote:
> Hey Jan,
>
> In my test setup this commit:
>
> 74cedf9b6c60 ("direct-io: Fix negative return from dio read beyond eof")
>
> causes a regression with XFS and the test generic/113. The test used to
> pass, but with the above mentioned commit it just hangs indefinitely.
>
> This commit went in between v4.4-rc3 and v4.4-rc4, and it looks like it was
> marked for stable?
See the tip of vfs.git#for-linus for fix...
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: v4.4-rc4 regression with direct-io
2015-12-08 21:51 ` Al Viro
@ 2015-12-08 23:14 ` Ross Zwisler
2015-12-09 11:49 ` Jan Kara
1 sibling, 0 replies; 4+ messages in thread
From: Ross Zwisler @ 2015-12-08 23:14 UTC (permalink / raw
To: Al Viro
Cc: Ross Zwisler, Jan Kara, stable, Steven Whitehouse, Avi Kivity,
Jens Axboe, linux-fsdevel, xfs, torvalds
On Tue, Dec 08, 2015 at 09:51:09PM +0000, Al Viro wrote:
> On Tue, Dec 08, 2015 at 02:39:02PM -0700, Ross Zwisler wrote:
> > Hey Jan,
> >
> > In my test setup this commit:
> >
> > 74cedf9b6c60 ("direct-io: Fix negative return from dio read beyond eof")
> >
> > causes a regression with XFS and the test generic/113. The test used to
> > pass, but with the above mentioned commit it just hangs indefinitely.
> >
> > This commit went in between v4.4-rc3 and v4.4-rc4, and it looks like it was
> > marked for stable?
>
> See the tip of vfs.git#for-linus for fix...
I've confirmed that this fixes my test case. Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: v4.4-rc4 regression with direct-io
2015-12-08 21:51 ` Al Viro
2015-12-08 23:14 ` Ross Zwisler
@ 2015-12-09 11:49 ` Jan Kara
1 sibling, 0 replies; 4+ messages in thread
From: Jan Kara @ 2015-12-09 11:49 UTC (permalink / raw
To: Al Viro
Cc: Ross Zwisler, Jan Kara, stable, Steven Whitehouse, Avi Kivity,
Jens Axboe, linux-fsdevel, xfs, torvalds
On Tue 08-12-15 21:51:09, Al Viro wrote:
> On Tue, Dec 08, 2015 at 02:39:02PM -0700, Ross Zwisler wrote:
> > Hey Jan,
> >
> > In my test setup this commit:
> >
> > 74cedf9b6c60 ("direct-io: Fix negative return from dio read beyond eof")
> >
> > causes a regression with XFS and the test generic/113. The test used to
> > pass, but with the above mentioned commit it just hangs indefinitely.
> >
> > This commit went in between v4.4-rc3 and v4.4-rc4, and it looks like it was
> > marked for stable?
>
> See the tip of vfs.git#for-linus for fix...
Ah, thanks for fixing this up! I'm just wondering how the test program I
was using could have passed because pread() I'm doing there must have
returned ENOMEM... Argh, I see. I have tested the problem with ext4 which
uses DIO_LOCKING mode and in that case 'retval' gets overwritten to 0 by
filemap_write_and_wait() call :-|.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-12-09 12:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-08 21:39 v4.4-rc4 regression with direct-io Ross Zwisler
2015-12-08 21:51 ` Al Viro
2015-12-08 23:14 ` Ross Zwisler
2015-12-09 11:49 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).