From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5886C14036D; Thu, 23 May 2024 11:06:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716462375; cv=none; b=tVqLomMxaQrI55Ps/xMwkK0eozcplrh3r84esQcy1K2EV7GALxIyqIB9ziIK8QB3k5syFcQoDI8K3aUQl6BZXDuRCSpZIVB/mVbaAO+aTc/PgJY+eufqNxy4PUdkthD0znH1Ap76p+ORMmMN0VejuHFJ87Rd1BBpBBtF03xOrtk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716462375; c=relaxed/simple; bh=ek0EsSX6tgjcxUNlOmx+2cgmh7cI2TdI2nY2nGFV9eE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=K7btZM/mtkUFcDIiUjrVM7fB/8836P5sqnga4sE3U7Ih3eKPuwk9vNKuCvMk0WnyCWs0lJlvX9VZ95M93glB31o73oXj1tpn1CjVqLg9g7krdhAnGunP3R+1vqUg2qM3NYbVm2LNFE84+nszhMSIi0luFuUqUyjMOAK+wB/x4Oo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=1cOj+JOT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="1cOj+JOT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A638C2BD10; Thu, 23 May 2024 11:06:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1716462375; bh=ek0EsSX6tgjcxUNlOmx+2cgmh7cI2TdI2nY2nGFV9eE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1cOj+JOT1Bs5ypEel49fchN3hcQEmYINhdjEsgK6Y2oE0DxxjuDnjXk+E4+uO0Z+9 Gfrfwe/AxWV6RuZiVHn+GqRxiL/2eq3DfXMWIpDkp6kX+2gVFWrrfaNRANy9QQbbfZ 9iJflMbANMDbf1SyMXBjIetnPzpeBxbfC+n14vN4= Date: Thu, 23 May 2024 13:06:12 +0200 From: Greg KH To: Leah Rumancik Cc: Amir Goldstein , stable@vger.kernel.org, linux-xfs@vger.kernel.org, chandan.babu@oracle.com, fred@cloudflare.com, Dave Chinner , Christoph Hellwig , "Darrick J . Wong" Subject: Re: [PATCH 6.1 01/24] xfs: write page faults in iomap are not buffered writes Message-ID: <2024052354-apache-footboard-d95a@gregkh> References: <20240501184112.3799035-1-leah.rumancik@gmail.com> <2024050436-conceded-idealness-d2c5@gregkh> <2024052207-curve-revered-b879@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, May 22, 2024 at 02:55:18PM -0700, Leah Rumancik wrote: > On Wed, May 22, 2024 at 7:11 AM Greg KH wrote: > > > > On Mon, May 06, 2024 at 10:52:16AM -0700, Leah Rumancik wrote: > > > Ah my bad, I'll make sure to explicitly mention its been ACK'd by > > > linux-xfs in the future. > > > > > > Will send out a MAINTAINERS file patch as well. > > > > Did that happen? > > Yep, https://lore.kernel.org/all/Zj9xj1wIzlTK8VCm@sashalap/ > > > > > Anyway, this patch series breaks the build: > > > > s/xfs/xfs_iomap.c: In function ‘xfs_iomap_inode_sequence’: > > fs/xfs/xfs_iomap.c:58:27: error: ‘IOMAP_F_XATTR’ undeclared (first use in this function); did you mean ‘IOP_XATTR’? > > 58 | if (iomap_flags & IOMAP_F_XATTR) > > | ^~~~~~~~~~~~~ > > | IOP_XATTR > > fs/xfs/xfs_iomap.c:58:27: note: each undeclared identifier is reported only once for each function it appears in > > fs/xfs/xfs_iomap.c: In function ‘xfs_iomap_valid’: > > fs/xfs/xfs_iomap.c:74:21: error: ‘const struct iomap’ has no member named ‘validity_cookie’ > > 74 | return iomap->validity_cookie == > > | ^~ > > fs/xfs/xfs_iomap.c: At top level: > > fs/xfs/xfs_iomap.c:79:10: error: ‘const struct iomap_page_ops’ has no member named ‘iomap_valid’ > > 79 | .iomap_valid = xfs_iomap_valid, > > | ^~~~~~~~~~~ > > fs/xfs/xfs_iomap.c:79:35: error: positional initialization of field in ‘struct’ declared with ‘designated_init’ attribute [-Werror=designated-init] > > 79 | .iomap_valid = xfs_iomap_valid, > > | ^~~~~~~~~~~~~~~ > > fs/xfs/xfs_iomap.c:79:35: note: (near initialization for ‘xfs_iomap_page_ops’) > > fs/xfs/xfs_iomap.c:79:35: error: invalid initializer > > fs/xfs/xfs_iomap.c:79:35: note: (near initialization for ‘xfs_iomap_page_ops.’) > > fs/xfs/xfs_iomap.c: In function ‘xfs_bmbt_to_iomap’: > > fs/xfs/xfs_iomap.c:127:14: error: ‘struct iomap’ has no member named ‘validity_cookie’ > > 127 | iomap->validity_cookie = sequence_cookie; > > | ^~ > > fs/xfs/xfs_iomap.c: In function ‘xfs_xattr_iomap_begin’: > > fs/xfs/xfs_iomap.c:1375:44: error: ‘IOMAP_F_XATTR’ undeclared (first use in this function); did you mean ‘IOP_XATTR’? > > 1375 | seq = xfs_iomap_inode_sequence(ip, IOMAP_F_XATTR); > > | ^~~~~~~~~~~~~ > > | IOP_XATTR > > fs/xfs/xfs_iomap.c:1382:1: error: control reaches end of non-void function [-Werror=return-type] > > 1382 | } > > | ^ > > cc1: all warnings being treated as errors > > > > > > Any chance you can rebase and resend it? > > > > Will do. Nope, this was my fault, the original series here is fine! Sorry for the noise, I'll go queue it up now. greg k-h