Stable Archive mirror
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Janaki Ramaiah Thota <quic_janathot@quicinc.com>
Cc: Doug Anderson <dianders@chromium.org>,
	Johan Hovold <johan+linaro@kernel.org>,
	Marcel Holtmann <marcel@holtmann.org>,
	Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
	linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org, quic_mohamull@quicinc.com,
	quic_hbandi@quicinc.com, quic_anubhavg@quicinc.com
Subject: Re: [PATCH] Bluetooth: qca: generalise device address check
Date: Mon, 29 Apr 2024 16:02:44 +0200	[thread overview]
Message-ID: <Zi-ohCWv58d2h5VM@hovoldconsulting.com> (raw)
In-Reply-To: <dbba45d2-f955-4d3a-aeab-26b0900d5823@quicinc.com>

Hi Janaki,

Please avoid top and remember to trim unnecessary context when replying
to the mailing lists.

On Mon, Apr 29, 2024 at 03:34:32PM +0530, Janaki Ramaiah Thota wrote:

> Having a default BDA list from NVM BDA tag value will prevent developers
> from using the device if there is no user space app(In Fluoride) to set
> the BDA. Therefore, we are requesting to use default address check patch,
> so that developer can change the NVM BDA to make use of the device.

But a developer on such an old platform that can patch and replace the
NVM configuration file should also be able to just disable the check in
the driver right (e.g. by commenting out the call to
qca_check_bdaddr())?

>   List Of default Addresses:
>   ---------------------------------------------------------
> |       BDA          |      Chipset                       |
>   ---------------------------------------------------------
> | 39 80 10 00 00 20  |  WCN3988 with ROM Version 0x0200   |
>   ---------------------------------------------------------
> | 39 80 12 74 08 00  |  WCN3988 with ROM Version 0x0201   |
>   ---------------------------------------------------------
> | 39 90 21 64 07 00  |  WCN3990                           |
>   ---------------------------------------------------------
> | 39 98 00 00 5A AD  |  WCN3991                           |
>   ---------------------------------------------------------
> | 00 00 00 00 5A AD  |  QCA DEFAULT                       |
>   ---------------------------------------------------------

What about WCN6750 and 64:90:00:00:5a:ad?

And then there's currently also:

> > bluetooth hci0: bd_addr = 61:47:aa:31:22:14 (qca/nvm_00130300.bin)
> > bluetooth hci0: bd_addr = 61:47:aa:32:44:07 (qca/nvm_00130302.bin)

Which controllers use these configurations?

Johan

  reply	other threads:[~2024-04-29 14:02 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-26 15:58 [PATCH] Bluetooth: qca: generalise device address check Johan Hovold
2024-04-26 17:23 ` Doug Anderson
2024-04-27  9:51   ` Johan Hovold
2024-04-29 10:04     ` Janaki Ramaiah Thota
2024-04-29 14:02       ` Johan Hovold [this message]
2024-04-29 14:06         ` Johan Hovold
2024-04-29 17:12         ` Luiz Augusto von Dentz
2024-04-29 17:31           ` Luiz Augusto von Dentz
2024-04-30  7:07             ` Johan Hovold
2024-04-30 12:52               ` Janaki Ramaiah Thota
2024-04-30 13:07                 ` Johan Hovold
2024-04-30 14:04                   ` Luiz Augusto von Dentz
2024-04-30 14:36                     ` Johan Hovold
2024-05-02  7:05                   ` Janaki Ramaiah Thota
2024-05-02 10:11                     ` Johan Hovold
2024-05-02 17:03                       ` Janaki Ramaiah Thota
2024-05-02 17:32                         ` Luiz Augusto von Dentz
2024-05-03  7:12                           ` Janaki Ramaiah Thota
2024-04-30 14:21     ` Luiz Augusto von Dentz
2024-04-30 14:38       ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zi-ohCWv58d2h5VM@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=dianders@chromium.org \
    --cc=johan+linaro@kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    --cc=quic_anubhavg@quicinc.com \
    --cc=quic_hbandi@quicinc.com \
    --cc=quic_janathot@quicinc.com \
    --cc=quic_mohamull@quicinc.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).