From: Sean Christopherson <seanjc@google.com>
To: Nicolas Saenz Julienne <nsaenz@amazon.com>
Cc: stable@vger.kernel.org, Maxim Levitsky <mlevitsk@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 5.15.y] KVM: x86: Clear "has_error_code", not "error_code", for RM exception injection
Date: Fri, 10 May 2024 08:43:38 -0700 [thread overview]
Message-ID: <Zj5AqkmfuRv33yve@google.com> (raw)
In-Reply-To: <20240510131002.19689-1-nsaenz@amazon.com>
On Fri, May 10, 2024, Nicolas Saenz Julienne wrote:
> From: Sean Christopherson <seanjc@google.com>
>
> When injecting an exception into a vCPU in Real Mode, suppress the error
> code by clearing the flag that tracks whether the error code is valid, not
> by clearing the error code itself. The "typo" was introduced by recent
> fix for SVM's funky Paged Real Mode.
>
> Opportunistically hoist the logic above the tracepoint so that the trace
> is coherent with respect to what is actually injected (this was also the
> behavior prior to the buggy commit).
>
> Fixes: b97f07458373 ("KVM: x86: determine if an exception has an error code only when injecting it.")
> Cc: stable@vger.kernel.org
> Cc: Maxim Levitsky <mlevitsk@redhat.com>
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> Message-Id: <20230322143300.2209476-2-seanjc@google.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> (cherry picked from commit 6c41468c7c12d74843bb414fc00307ea8a6318c3)
> [nsaenz: backport to 5.15.y]
> Signed-off-by: Nicolas Saenz Julienne <nsaenz@amazon.com>
>
> Conflicts:
> arch/x86/kvm/x86.c: Patch offsets had to be corrected.
> ---
Acked-by: Sean Christopherson <seanjc@google.com>
prev parent reply other threads:[~2024-05-10 15:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 11:00 FAILED: patch "[PATCH] KVM: x86: Clear "has_error_code", not "error_code", for RM" failed to apply to 5.15-stable tree gregkh
2024-05-10 13:10 ` [PATCH 5.15.y] KVM: x86: Clear "has_error_code", not "error_code", for RM exception injection Nicolas Saenz Julienne
2024-05-10 15:43 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zj5AqkmfuRv33yve@google.com \
--to=seanjc@google.com \
--cc=mlevitsk@redhat.com \
--cc=nsaenz@amazon.com \
--cc=pbonzini@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).