From: Sascha Hauer <s.hauer@pengutronix.de>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Pratyush Yadav <pratyush@kernel.org>,
Michael Walle <michael@walle.cc>,
linux-mtd@lists.infradead.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] mtd: rawnand: Ensure ECC configuration is propagated to upper layers
Date: Tue, 7 May 2024 14:37:38 +0200 [thread overview]
Message-ID: <ZjogkgrQ46H1hXSi@pengutronix.de> (raw)
In-Reply-To: <20240507085842.108844-1-miquel.raynal@bootlin.com>
Hi Miquel,
On Tue, May 07, 2024 at 10:58:42AM +0200, Miquel Raynal wrote:
> Until recently the "upper layer" was MTD. But following incremental
> reworks to bring spi-nand support and more recently generic ECC support,
> there is now an intermediate "generic NAND" layer that also needs to get
> access to some values. When using "converted" ECC engines, like the
> software ones, these values are already propagated correctly. But
> otherwise when using good old raw NAND controller drivers, we need to
> manually set these values ourselves at the end of the "scan" operation,
> once these values have been negotiated.
>
> Without this propagation, later (generic) checks like the one warning
> users that the ECC strength is not high enough might simply no longer
> work.
>
> Fixes: 8c126720fe10 ("mtd: rawnand: Use the ECC framework nand_ecc_is_strong_enough() helper")
> Cc: stable@vger.kernel.org
> Reported-by: Sascha Hauer <s.hauer@pengutronix.de>
> Closes: https://lore.kernel.org/all/Zhe2JtvvN1M4Ompw@pengutronix.de/
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>
> Hello Sascha, this is only compile tested, would you mind checking if
> that fixes your setup?
Works as expected:
Tested-by: Sascha Hauer <s.hauer@pengutronix.de>
Sascha
> Thanks, Miquèl
>
> drivers/mtd/nand/raw/nand_base.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
> index d7dbbd469b89..acd137dd0957 100644
> --- a/drivers/mtd/nand/raw/nand_base.c
> +++ b/drivers/mtd/nand/raw/nand_base.c
> @@ -6301,6 +6301,7 @@ static const struct nand_ops rawnand_ops = {
> static int nand_scan_tail(struct nand_chip *chip)
> {
> struct mtd_info *mtd = nand_to_mtd(chip);
> + struct nand_device *base = &chip->base;
> struct nand_ecc_ctrl *ecc = &chip->ecc;
> int ret, i;
>
> @@ -6445,9 +6446,13 @@ static int nand_scan_tail(struct nand_chip *chip)
> if (!ecc->write_oob_raw)
> ecc->write_oob_raw = ecc->write_oob;
>
> - /* propagate ecc info to mtd_info */
> + /* Propagate ECC info to the generic NAND and MTD layers */
> mtd->ecc_strength = ecc->strength;
> + if (!base->ecc.ctx.conf.strength)
> + base->ecc.ctx.conf.strength = ecc->strength;
> mtd->ecc_step_size = ecc->size;
> + if (!base->ecc.ctx.conf.step_size)
> + base->ecc.ctx.conf.step_size = ecc->size;
>
> /*
> * Set the number of read / write steps for one page depending on ECC
> @@ -6455,6 +6460,8 @@ static int nand_scan_tail(struct nand_chip *chip)
> */
> if (!ecc->steps)
> ecc->steps = mtd->writesize / ecc->size;
> + if (!base->ecc.ctx.nsteps)
> + base->ecc.ctx.nsteps = ecc->steps;
> if (ecc->steps * ecc->size != mtd->writesize) {
> WARN(1, "Invalid ECC parameters\n");
> ret = -EINVAL;
> --
> 2.40.1
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2024-05-07 12:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 8:58 [PATCH] mtd: rawnand: Ensure ECC configuration is propagated to upper layers Miquel Raynal
2024-05-07 12:37 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjogkgrQ46H1hXSi@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=stable@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).