From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Dipen Patel <dipenp@nvidia.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
timestamp@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hte: tegra194: add GPIOLIB dependency
Date: Mon, 23 Oct 2023 14:00:42 +0200 [thread overview]
Message-ID: <CAMRc=MdoRWn_grWoKWagAi11S=mZ9RbP673L77a+qfN_8oTBcg@mail.gmail.com> (raw)
In-Reply-To: <20231023115646.3573494-1-arnd@kernel.org>
On Mon, Oct 23, 2023 at 1:57 PM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> The driver started calling into a few interfaces that are part of GPIOLIB and
> don't have stub implementations otherwise:
>
> drivers/hte/hte-tegra194.c: In function 'tegra_hte_line_xlate':
> drivers/hte/hte-tegra194.c:424:48: error: implicit declaration of function 'gpio_device_get_base'; did you mean 'gpio_device_get_desc'? [-Werror=implicit-function-declaration]
> 424 | line_id = desc->attr.line_id - gpio_device_get_base(gs->gdev);
> | ^~~~~~~~~~~~~~~~~~~~
> | gpio_device_get_desc
>
> Add a Kconfig dependency to only allow building when this is defined.
>
> Fixes: dc850faa28ee0 ("hte: tegra194: don't access struct gpio_chip")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/hte/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hte/Kconfig b/drivers/hte/Kconfig
> index 083e67492bf2e..641af722b555d 100644
> --- a/drivers/hte/Kconfig
> +++ b/drivers/hte/Kconfig
> @@ -17,6 +17,7 @@ if HTE
> config HTE_TEGRA194
> tristate "NVIDIA Tegra194 HTE Support"
> depends on (ARCH_TEGRA_194_SOC || COMPILE_TEST)
> + depends on GPIOLIB
> help
> Enable this option for integrated hardware timestamping engine also
> known as generic timestamping engine (GTE) support on NVIDIA Tegra194
> --
> 2.39.2
>
Thanks. None of the new interfaces are "consumer" APIs and are not
meant to have stubs so depending on GPIOLIB is correct here.
Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
next prev parent reply other threads:[~2023-10-23 12:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 11:56 [PATCH] hte: tegra194: add GPIOLIB dependency Arnd Bergmann
2023-10-23 12:00 ` Bartosz Golaszewski [this message]
2023-10-23 12:02 ` Bartosz Golaszewski
2023-10-23 17:26 ` Dipen Patel
2023-10-23 18:20 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRc=MdoRWn_grWoKWagAi11S=mZ9RbP673L77a+qfN_8oTBcg@mail.gmail.com' \
--to=brgl@bgdev.pl \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=dipenp@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=timestamp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).