From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: tools@linux.kernel.org, Conor Dooley <conor.dooley@microchip.com>
Cc: conor@kernel.org, palmer@dabbelt.com,
Palmer Dabbelt <palmer@rivosinc.com>
Subject: Re: [PATCH] shazam: warn when overriding base-commit with --merge-base
Date: Fri, 26 May 2023 14:25:55 -0400 [thread overview]
Message-ID: <168512555540.61991.10042284962793080066.b4-ty@linuxfoundation.org> (raw)
In-Reply-To: <20230330110909.355701-1-conor.dooley@microchip.com>
On Thu, 30 Mar 2023 12:09:10 +0100, Conor Dooley wrote:
> If the --merge-base argument is provided, base-commit information that
> was provided by the submitter is ignored. This behaviour is intentional,
> but warning the user that this has happened (and what the intended base
> was) is helpful.
>
> To be able to do this, base-commit can't be set from mergebase until
> after parsing the submission and attempting to guess it.
>
> [...]
Applied, thanks!
[1/1] shazam: warn when overriding base-commit with --merge-base
commit: 91592bf5d05f312225bf4f49d8bcc9508041bee2
Best regards,
--
Konstantin Ryabitsev <konstantin@linuxfoundation.org>
prev parent reply other threads:[~2023-05-26 18:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 11:09 [PATCH] shazam: warn when overriding base-commit with --merge-base Conor Dooley
2023-03-30 20:25 ` Palmer Dabbelt
2023-05-26 18:25 ` Konstantin Ryabitsev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168512555540.61991.10042284962793080066.b4-ty@linuxfoundation.org \
--to=konstantin@linuxfoundation.org \
--cc=conor.dooley@microchip.com \
--cc=conor@kernel.org \
--cc=palmer@dabbelt.com \
--cc=palmer@rivosinc.com \
--cc=tools@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).