Linux maintainer tooling and workflows
 help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: tools@linux.kernel.org
Subject: b4 tag parsing too lax?
Date: Wed, 13 Sep 2023 12:44:43 -0700	[thread overview]
Message-ID: <202309131243.5D508355@keescook> (raw)

Hi,

I just saw this in commit ef6e1997da63 ("wifi: mac80211: fortify the
spinlock against deadlock by interrupt"):

  Reviewed-by: tag, or it goes automatically?

I tracked it down to:

https://lore.kernel.org/all/074cf5ed-c39d-1c16-12e7-4b14bbe0cac4@alu.unizg.hr/

I can't tell if we should just deal with kind of unfortunate misparsing,
or if b4 should require at least a "@" in the tag? (Though plenty of
tags are just someone's name without an email in the cases where no
email was available...)

-Kees

-- 
Kees Cook

             reply	other threads:[~2023-09-13 19:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-13 19:44 Kees Cook [this message]
2023-09-13 20:00 ` b4 tag parsing too lax? Konstantin Ryabitsev
2023-09-13 23:04   ` Kees Cook
2023-09-14  6:55     ` Johannes Berg
2023-09-14 13:44       ` Konstantin Ryabitsev
2023-09-14 16:55       ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202309131243.5D508355@keescook \
    --to=keescook@chromium.org \
    --cc=tools@linux.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).