Linux maintainer tooling and workflows
 help / color / mirror / Atom feed

From: Matthieu Baerts <matthieu.baerts@tessares.net>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: Tools <tools@linux.kernel.org>
Subject: b4: idea: checkpatch.pl integration / hook support
Date: Tue, 31 Jan 2023 17:06:51 +0100	[thread overview]
Message-ID: <233f0440-7f20-6edf-256c-b8ebec53539e@tessares.net> (raw)

Hi Konstantin,

First, thank you for developing and maintaining this great tool!

B4 works very well to send patches. But there are quite a few steps and
I think it is easy to forget one :)

For some like "b4 prep --auto-to-cc", that's probably OK to miss this
command because "b4 send" will mention that these patches will only be
sent to the author + other emails found in the patches. (It might be
interesting to have a more visible warning / confirmation if no
addresses are found in the cover-letter but that's not my main point here.)

But for 'checkpatch.pl' or other scripts specific to some subsystems,
there will be no reminders from "b4 send" to check that.


Do you think it could be possible to integrate such tool to b4 if available?

For the moment, I do this before a "b4 send":

  ./scripts/checkpatch.pl --strict --codespell \
   --git $(b4 prep --show-info | awk '/^start-commit: / { print $2 }')..

(checkpatch doesn't seem to support empty patches, we have to skip it)

What do you think about having a list of hooks that can be added in
b4-config file?

For occasional contributors, it could be nice if it is automatically
executed before sending a patch. But I understand there might be other
issues to deal with: missing dependences, false positives, different
rules per subsystem, etc. A mention in the doc and/or before sending the
patches might be enough.

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net

next             reply	other threads:[~2023-01-31 16:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-31 16:06 Matthieu Baerts [this message]
2023-02-01 21:47 ` b4: idea: checkpatch.pl integration / hook support Konstantin Ryabitsev
2023-02-02 10:18   ` Matthieu Baerts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=233f0440-7f20-6edf-256c-b8ebec53539e@tessares.net \
    --to=matthieu.baerts@tessares.net \
    --cc=konstantin@linuxfoundation.org \
    --cc=tools@linux.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).