From: Nathan Chancellor <nathan@kernel.org>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: tools@linux.kernel.org
Subject: Re: Address from trailer on individual patch is sent entire series?
Date: Fri, 6 Jan 2023 09:54:31 -0700 [thread overview]
Message-ID: <Y7hSRwJd8GbNUNeW@dev-arch.thelio-3990X> (raw)
In-Reply-To: <20230106163442.aziaoa3tndqtyisp@meerkat.local>
On Fri, Jan 06, 2023 at 11:34:42AM -0500, Konstantin Ryabitsev wrote:
> On Thu, Jan 05, 2023 at 06:27:09PM -0700, Nathan Chancellor wrote:
> > Hi Konstantin,
> >
> > I was going over my recent "sent with b4" series and I noticed that the
> > kernel test robot, a Reported-by: on a specific patch in the series, was
> > Cc'd on the entire series.
>
> This is one of those time when people's expectations diverge and either way
> you do it, someone will find that it's not how they want it to work.
>
> Originally, my polling suggested that everyone always wanted to receive the
> entire patch series, even if they were only responsible for a single patch.
> This was later changed for in-patch "Cc:" trailers, because there were actual
> CI workflows based on that and sending them the entire series was causing more
> harm than good.
>
> However, every other trailer will still receive the entire series, because I
> believe it's still more correct than just sending them a single patch.
Understood, thanks for taking the time to explain your rationale!
I am sure you are aware this contradicts what git send-email does, which
is obviously fine in and of itself (I understand b4 is not a git
send-email clone), but I am not sure this difference will be for the
better.
For example, take the series I just mentioned in my previous mail. There
are only three patches that are relevant to the s390 folks, so
previously I Cc'd them on just those three patches along with the cover
letter so that is what clear what I was expecting (tags for those three
patches so they could be carried via another tree). I promptly got a
review and ack from Sven and Heiko respectively, which I added to the
relevant patches in my local tree.
If I have to send a v2, Heiko and Sven are going to get Cc'd on the
entire series, which is now entirely irrelevant to them, versus getting
just those few patches, which they can recognized as ones that they have
already dealt with. I suppose I am going to get bit by this more often
than others will because I work all over the tree so perhaps it is not
that big of a concern in practice.
> If that's not the actual consensus and we decide that all other
> in-patch trailers should be handled the same as Cc: (they get the
> cover letter plus only the individual patches where they are cc'd), I
> can certainly implement that as well.
It would be good to poll others to see what they think, as I could be
way off base here.
Cheers,
Nathan
next prev parent reply other threads:[~2023-01-06 16:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 1:27 Address from trailer on individual patch is sent entire series? Nathan Chancellor
2023-01-06 16:34 ` Konstantin Ryabitsev
2023-01-06 16:54 ` Nathan Chancellor [this message]
2023-01-06 19:20 ` Konstantin Ryabitsev
2023-01-06 19:43 ` Nathan Chancellor
2023-01-07 0:12 ` Konstantin Ryabitsev
2023-01-07 0:39 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7hSRwJd8GbNUNeW@dev-arch.thelio-3990X \
--to=nathan@kernel.org \
--cc=konstantin@linuxfoundation.org \
--cc=tools@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).