From: Vishal Verma <vishal@kernel.org>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: tools@linux.kernel.org
Subject: Re: b4 prep + prefix handling
Date: Fri, 09 Dec 2022 14:18:48 -0700 [thread overview]
Message-ID: <e2ad3a972e389176c3c0dfce128a115e2ceaf2ae.camel@kernel.org> (raw)
In-Reply-To: <20221209211102.qeyyon3mxztcn2lx@meerkat.local>
On Fri, 2022-12-09 at 16:11 -0500, Konstantin Ryabitsev wrote:
> On Tue, Dec 06, 2022 at 03:44:59PM -0700, Vishal Verma wrote:
> > Hi Konstantin,
> >
> > I found a possible issue with prefixes - and also a suggestion below:
> >
> > - When a 'git config format.subjectprefix' exists, b4 send does
> > something unexpected:
> > (the .git/config subjectprefix here was "ndctl PATCH")
> >
> > | Subject: [PATCH 2/2] [ndctl PATCH] meson.build: add a check argument to run_command
> >
> > - It might be helpful to configure whether the final form is "PATCH
> > prefix" vs "prefix PATCH". I'm used to the latter, but I don't know if
> > the former is considered conventional.
> >
> > - It might be nice if prefixes from git-config could be added
> > automagically (perhaps b4 prep pulls these in when starting a new
> > set?). I have prefixes based on repos sometimes, like the above
> > example, and it would be nice to get consistent behavior regardless of
> > whether 'b4 prep/send' is used or 'git format-patch/send-email'
>
> Vishal:
>
> I believe the latest master should be able to properly co-exist with prefixes
> set via format.subjectPrefix and those set directly via b4.
>
> Please try it out and let me know if it's not what you need.
Yep works great now - it gets pulled automatically from the git config,
without needing to b4 prep --set-prefixes
Thanks for the quick fix!
prev parent reply other threads:[~2022-12-09 21:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 22:44 b4 prep + prefix handling Vishal Verma
2022-12-09 21:11 ` Konstantin Ryabitsev
2022-12-09 21:18 ` Vishal Verma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2ad3a972e389176c3c0dfce128a115e2ceaf2ae.camel@kernel.org \
--to=vishal@kernel.org \
--cc=konstantin@linuxfoundation.org \
--cc=tools@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).