From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Greg KH <greg@kroah.com>
Cc: Paul Menzel <pmenzel@molgen.mpg.de>,
tpmdd-devel@lists.sourceforge.net,
linux-security-module@vger.kernel.org,
"Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
stable@vger.kernel.org, Peter Huewe <peterhuewe@gmx.de>,
Marcel Selhorst <tpmdd@selhorst.net>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [tpmdd-devel] [backport v4.9] tpm_tis: use default timeout value if chip reports it as zero
Date: Sun, 23 Apr 2017 15:14:00 +0300 [thread overview]
Message-ID: <20170423121400.ki7vuvn3xwtiaocr@intel.com> (raw)
In-Reply-To: <20170419153807.GB10969@kroah.com>
On Wed, Apr 19, 2017 at 05:38:07PM +0200, Greg KH wrote:
> On Wed, Apr 19, 2017 at 06:29:08PM +0300, Jarkko Sakkinen wrote:
> > On Sun, Apr 16, 2017 at 09:14:29PM +0200, Paul Menzel wrote:
> > > Dear Greg,
> > >
> > >
> > > On 2017-04-15 22:50, Greg KH wrote:
> > > > On Sat, Apr 15, 2017 at 06:26:22PM +0300, Jarkko Sakkinen wrote:
> > > > > From: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
> > > > >
> > > > > Since commit 1107d065fdf1 ("tpm_tis: Introduce intermediate layer for
> > > > > TPM access") Atmel 3203 TPM on ThinkPad X61S (TPM firmware version
> > > > > 13.9)
> > > > > no longer works. The initialization proceeds fine until we get and
> > > > > start using chip-reported timeouts - and the chip reports C and D
> > > > > timeouts of zero.
> > > > >
> > > > > It turns out that until commit 8e54caf407b98e ("tpm: Provide a generic
> > > > > means to override the chip returned timeouts") we had actually let
> > > > > default timeout values remain in this case, so let's bring back this
> > > > > behavior to make chips like Atmel 3203 work again.
> > > > >
> > > > > Use a common code that was introduced by that commit so a warning is
> > > > > printed in this case and /sys/class/tpm/tpm*/timeouts correctly says
> > > > > the
> > > > > timeouts aren't chip-original.
> > > > >
> > > > > Fixes: 1107d065fdf1 ("tpm_tis: Introduce intermediate layer for TPM
> > > > > access")
> > > > > Cc: stable@vger.kernel.org
> > > > > Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
> > > > > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > > > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > > >
> > > > What is the git commit id for this patch in Linus's tree?
> > >
> > > The git commit hash is 1d70fe9d9c3a4c627f9757cbba5d628687b121c1.
> > >
> > >
> > > Kind regards,
> > >
> > > Paul
> >
> > Do you want me to revise the backport? Thanks.
>
> I can't take it as-is, so yes, if you want it applied, it needs to be
> fixed :)
>
> thanks,
>
> greg k-h
I will send it asap. Thanks.
/Jarkko
prev parent reply other threads:[~2017-04-23 12:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-15 15:26 [backport v4.9] tpm_tis: use default timeout value if chip reports it as zero Unknown, Jarkko Sakkinen
2017-04-15 16:04 ` Maciej S. Szmigiero
[not found] ` <420a825b-9845-7029-482c-aec297265107-APzI5cXaD1zVlRWJc41N0YvC60bnQu0Y@public.gmane.org>
2017-04-19 15:12 ` Jarkko Sakkinen
2017-04-15 20:50 ` Greg KH
2017-04-16 19:14 ` [tpmdd-devel] " Paul Menzel
[not found] ` <79399e000218504619c21ce6729c8334-KUpvgZVWgV9o1qOY/usvUg@public.gmane.org>
2017-04-19 15:29 ` Jarkko Sakkinen
2017-04-19 15:38 ` [tpmdd-devel] " Greg KH
2017-04-23 12:14 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170423121400.ki7vuvn3xwtiaocr@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=greg@kroah.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
--cc=peterhuewe@gmx.de \
--cc=pmenzel@molgen.mpg.de \
--cc=stable@vger.kernel.org \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).