From: Josh Zimmerman <joshz-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
To: Jason Gunthorpe
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
"Rafael J. Wysocki"
<rafael-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH] tpm_tis: Issue a TPM2_Shutdown for TPM2 devices.
Date: Mon, 8 May 2017 11:32:34 -0700 [thread overview]
Message-ID: <CAHSjozD1-Sa5=7_i5G5ZnnjbzGj5ng6yBjx9mhMff7sP36iR7w@mail.gmail.com> (raw)
In-Reply-To: <20170508182415.GA32332-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Ah, yes, right. Too early on Monday still :)
Josh
On Mon, May 8, 2017 at 11:24 AM, Jason Gunthorpe
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> wrote:
> On Mon, May 08, 2017 at 11:16:56AM -0700, Josh Zimmerman wrote:
>> Hm, according to include/linux/pm.h,
>>
>> * It is allowed to unregister devices while the above callbacks are being
>> * executed. However, a callback routine MUST NOT try to
>> unregister the device
>> * it was called for, although it may unregister children of that device (for
>> * example, if it detects that a child was unplugged while the system was
>> * asleep).
>>
>> So, it seems if we want to add shutdown to class->pm, we'll need to do
>> the refactoring for sysfs now to avoid the implicit lock in order to
>> safely NULL out chip->ops. (Otherwise, I believe we'd need to
>> unregister.)\\
>>
>> I'll start work on that, but I wanted to send this email first to
>> double-check that my understanding was correct and I wasn't missing an
>> easier path.
>
> Like I said, if you guard shutdown with a 'if TPM2' then the sysfs
> case cannot occur..
>
> It eventually needs to be fixed for TPM1, but a TPM2 only first step
> would be OK too.
>
> Jason
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
next prev parent reply other threads:[~2017-05-08 18:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 18:26 [PATCH] tpm_tis: Issue a TPM2_Shutdown for TPM2 devices Josh Zimmerman
[not found] ` <20170427182659.403-1-joshz-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2017-04-27 20:49 ` Jason Gunthorpe
[not found] ` <20170427204912.GA26330-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-04-28 12:24 ` Jarkko Sakkinen
2017-04-28 12:12 ` Jarkko Sakkinen
[not found] ` <20170428121226.7xnpfbxcjszrnz5d-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-04-28 15:27 ` Jason Gunthorpe
[not found] ` <20170428152748.GA32017-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-04-28 18:27 ` Josh Zimmerman
[not found] ` <CAHSjozC=1GgKazv5m19X6Oe321+mkMUFCfFBQ=_c7kPQ-WESDA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-28 18:43 ` Jason Gunthorpe
[not found] ` <20170428184325.GA15327-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-04-28 21:32 ` Josh Zimmerman
[not found] ` <CAHSjozDRHbuHD6dPfTGMnF4j66hPV-_WiD22y5WRpawPFMQmfQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-28 21:39 ` Jason Gunthorpe
[not found] ` <20170428213905.GA19326-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-04-28 21:45 ` Rafael J. Wysocki
[not found] ` <CAJZ5v0iFkLfmeQgZyQDoKF42=RQw6q_GdK3fLgwdC9_mDbJKjg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-28 22:16 ` Jason Gunthorpe
[not found] ` <20170428221648.GA25935-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-04-28 23:30 ` Josh Zimmerman
2017-05-05 22:39 ` Josh Zimmerman
[not found] ` <CAHSjozCROVK=ca8tO+zNC+JD3a0+hQ-54AE7jGndrrs2nG1O1A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-05 22:46 ` Jason Gunthorpe
[not found] ` <20170505224629.GA15229-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-05-08 18:16 ` Josh Zimmerman
[not found] ` <CAHSjozCaWoQuQiWJ59_UyXnrnq=eh4sucLGgJ=0me6A0NHYsBA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-08 18:24 ` Jason Gunthorpe
[not found] ` <20170508182415.GA32332-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-05-08 18:32 ` Josh Zimmerman [this message]
2017-04-28 22:07 ` Josh Zimmerman
[not found] ` <CAHSjozA0-NVB1Nbr3DQ-2tsY3jVa6ADYUECfXjkNJWL3tfhWNA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-28 22:24 ` Jason Gunthorpe
[not found] ` <20170428222439.GB25935-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-04-29 11:53 ` Jarkko Sakkinen
2017-04-29 11:52 ` Jarkko Sakkinen
2017-04-29 11:48 ` Jarkko Sakkinen
2017-04-29 11:40 ` Jarkko Sakkinen
[not found] ` <20170429114013.67xwbv6xozarcieq-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-04-29 15:30 ` Jerry Snitselaar
2017-05-03 12:42 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHSjozD1-Sa5=7_i5G5ZnnjbzGj5ng6yBjx9mhMff7sP36iR7w@mail.gmail.com' \
--to=joshz-hpiqsd4aklfqt0dzr+alfa@public.gmane.org \
--cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
--cc=rafael-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).