* [PATCH 1/1] lib: disable CONFIG_SPL_HEXDUMP by default
@ 2021-07-24 15:35 Heinrich Schuchardt
2021-07-25 9:23 ` Michael Walle
2021-07-27 9:51 ` Patrick DELAUNAY
0 siblings, 2 replies; 3+ messages in thread
From: Heinrich Schuchardt @ 2021-07-24 15:35 UTC (permalink / raw
To: Tom Rini; +Cc: Simon Glass, u-boot, u-boot-board-maintainers,
Heinrich Schuchardt
CONFIG_HEXDUMP is needed to display UEFI variables using 'printenv -e'.
Enabling CONFIG_SPL_HEXDUMP only makes sense for debugging purposes.
Hence CONFIG_SPL_HEXDUMP should not be enabled by default.
The following boards currently have CONFIG_SPL_HEXDUMP=y:
axm_defconfig
imx8mm-cl-iot-gate_defconfig
imx8mm_venice_defconfig
imxrt1020-evk_defconfig
imxrt1050-evk_defconfig
kontron_sl28_defconfig
kp_imx53_defconfig
lx2160ardb_tfa_stmm_defconfig
mt7622_rfb_defconfig
octeon_ebb7304_defconfig
octeon_nic23_defconfig
qemu_arm64_defconfig
qemu_arm_defconfig
qemu-riscv32_defconfig
qemu-riscv32_smode_defconfig
qemu-riscv64_defconfig
qemu-riscv64_smode_defconfig
qemu-x86_64_defconfig
qemu-x86_defconfig
sandbox64_defconfig
sandbox_defconfig
stm32mp15_basic_defconfig
stm32mp15_trusted_defconfig
synquacer_developerbox_defconfig
taurus_defconfig
xilinx_versal_virt_defconfig
The patch only keeps it enabled on
sandbox64_defconfig
sandbox_defconfig
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
configs/sandbox64_defconfig | 1 +
configs/sandbox_defconfig | 1 +
lib/Kconfig | 1 -
3 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/configs/sandbox64_defconfig b/configs/sandbox64_defconfig
index 5fb1da49e4..9e3c2d5e41 100644
--- a/configs/sandbox64_defconfig
+++ b/configs/sandbox64_defconfig
@@ -233,6 +233,7 @@ CONFIG_CMD_DHRYSTONE=y
CONFIG_TPM=y
CONFIG_LZ4=y
CONFIG_ERRNO_STR=y
+CONFIG_SPL_HEXDUMP=y
CONFIG_EFI_RUNTIME_UPDATE_CAPSULE=y
CONFIG_EFI_CAPSULE_ON_DISK=y
CONFIG_EFI_CAPSULE_FIRMWARE_FIT=y
diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig
index a1e77a511d..7e8694100c 100644
--- a/configs/sandbox_defconfig
+++ b/configs/sandbox_defconfig
@@ -281,6 +281,7 @@ CONFIG_CMD_DHRYSTONE=y
CONFIG_TPM=y
CONFIG_LZ4=y
CONFIG_ERRNO_STR=y
+CONFIG_SPL_HEXDUMP=y
CONFIG_EFI_RUNTIME_UPDATE_CAPSULE=y
CONFIG_EFI_CAPSULE_ON_DISK=y
CONFIG_EFI_CAPSULE_FIRMWARE_FIT=y
diff --git a/lib/Kconfig b/lib/Kconfig
index ad4d75e0a4..b0ea4cf91c 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -559,7 +559,6 @@ config HEXDUMP
config SPL_HEXDUMP
bool "Enable hexdump in SPL"
depends on HEXDUMP
- default y
help
This enables functions for printing dumps of binary data in
SPL.
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] lib: disable CONFIG_SPL_HEXDUMP by default
2021-07-24 15:35 [PATCH 1/1] lib: disable CONFIG_SPL_HEXDUMP by default Heinrich Schuchardt
@ 2021-07-25 9:23 ` Michael Walle
2021-07-27 9:51 ` Patrick DELAUNAY
1 sibling, 0 replies; 3+ messages in thread
From: Michael Walle @ 2021-07-25 9:23 UTC (permalink / raw
To: Heinrich Schuchardt
Cc: Tom Rini, Simon Glass, u-boot, u-boot-board-maintainers
Am 2021-07-24 17:35, schrieb Heinrich Schuchardt:
> CONFIG_HEXDUMP is needed to display UEFI variables using 'printenv -e'.
>
> Enabling CONFIG_SPL_HEXDUMP only makes sense for debugging purposes.
> Hence CONFIG_SPL_HEXDUMP should not be enabled by default.
>
> The following boards currently have CONFIG_SPL_HEXDUMP=y:
>
> axm_defconfig
> imx8mm-cl-iot-gate_defconfig
> imx8mm_venice_defconfig
> imxrt1020-evk_defconfig
> imxrt1050-evk_defconfig
> kontron_sl28_defconfig
> kp_imx53_defconfig
> lx2160ardb_tfa_stmm_defconfig
> mt7622_rfb_defconfig
> octeon_ebb7304_defconfig
> octeon_nic23_defconfig
> qemu_arm64_defconfig
> qemu_arm_defconfig
> qemu-riscv32_defconfig
> qemu-riscv32_smode_defconfig
> qemu-riscv64_defconfig
> qemu-riscv64_smode_defconfig
> qemu-x86_64_defconfig
> qemu-x86_defconfig
> sandbox64_defconfig
> sandbox_defconfig
> stm32mp15_basic_defconfig
> stm32mp15_trusted_defconfig
> synquacer_developerbox_defconfig
> taurus_defconfig
> xilinx_versal_virt_defconfig
>
> The patch only keeps it enabled on
>
> sandbox64_defconfig
> sandbox_defconfig
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Acked-by: Michael Walle <michael@walle.cc> # for kontron_sl28_defconfig
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] lib: disable CONFIG_SPL_HEXDUMP by default
2021-07-24 15:35 [PATCH 1/1] lib: disable CONFIG_SPL_HEXDUMP by default Heinrich Schuchardt
2021-07-25 9:23 ` Michael Walle
@ 2021-07-27 9:51 ` Patrick DELAUNAY
1 sibling, 0 replies; 3+ messages in thread
From: Patrick DELAUNAY @ 2021-07-27 9:51 UTC (permalink / raw
To: Heinrich Schuchardt, Tom Rini
Cc: Simon Glass, u-boot, u-boot-board-maintainers, Patrice CHOTARD,
U-Boot STM32
On 7/24/21 5:35 PM, Heinrich Schuchardt wrote:
> CONFIG_HEXDUMP is needed to display UEFI variables using 'printenv -e'.
>
> Enabling CONFIG_SPL_HEXDUMP only makes sense for debugging purposes.
> Hence CONFIG_SPL_HEXDUMP should not be enabled by default.
>
> The following boards currently have CONFIG_SPL_HEXDUMP=y:
>
> axm_defconfig
> imx8mm-cl-iot-gate_defconfig
> imx8mm_venice_defconfig
> imxrt1020-evk_defconfig
> imxrt1050-evk_defconfig
> kontron_sl28_defconfig
> kp_imx53_defconfig
> lx2160ardb_tfa_stmm_defconfig
> mt7622_rfb_defconfig
> octeon_ebb7304_defconfig
> octeon_nic23_defconfig
> qemu_arm64_defconfig
> qemu_arm_defconfig
> qemu-riscv32_defconfig
> qemu-riscv32_smode_defconfig
> qemu-riscv64_defconfig
> qemu-riscv64_smode_defconfig
> qemu-x86_64_defconfig
> qemu-x86_defconfig
> sandbox64_defconfig
> sandbox_defconfig
> stm32mp15_basic_defconfig
> stm32mp15_trusted_defconfig
> synquacer_developerbox_defconfig
> taurus_defconfig
> xilinx_versal_virt_defconfig
>
> The patch only keeps it enabled on
>
> sandbox64_defconfig
> sandbox_defconfig
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> configs/sandbox64_defconfig | 1 +
> configs/sandbox_defconfig | 1 +
> lib/Kconfig | 1 -
> 3 files changed, 2 insertions(+), 1 deletion(-)
>
Acked-by: Patrick Delaunay <patrick.delaunay@foss.st.com> # for
stm32mp15_*_defconfig
but it is strange for "stm32mp15_trusted_defconfig" as this
configuration don't enable the SPL support(see after).
> diff --git a/configs/sandbox64_defconfig b/configs/sandbox64_defconfig
> index 5fb1da49e4..9e3c2d5e41 100644
> --- a/configs/sandbox64_defconfig
> +++ b/configs/sandbox64_defconfig
> @@ -233,6 +233,7 @@ CONFIG_CMD_DHRYSTONE=y
> CONFIG_TPM=y
> CONFIG_LZ4=y
> CONFIG_ERRNO_STR=y
> +CONFIG_SPL_HEXDUMP=y
> CONFIG_EFI_RUNTIME_UPDATE_CAPSULE=y
> CONFIG_EFI_CAPSULE_ON_DISK=y
> CONFIG_EFI_CAPSULE_FIRMWARE_FIT=y
> diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig
> index a1e77a511d..7e8694100c 100644
> --- a/configs/sandbox_defconfig
> +++ b/configs/sandbox_defconfig
> @@ -281,6 +281,7 @@ CONFIG_CMD_DHRYSTONE=y
> CONFIG_TPM=y
> CONFIG_LZ4=y
> CONFIG_ERRNO_STR=y
> +CONFIG_SPL_HEXDUMP=y
> CONFIG_EFI_RUNTIME_UPDATE_CAPSULE=y
> CONFIG_EFI_CAPSULE_ON_DISK=y
> CONFIG_EFI_CAPSULE_FIRMWARE_FIT=y
> diff --git a/lib/Kconfig b/lib/Kconfig
> index ad4d75e0a4..b0ea4cf91c 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -559,7 +559,6 @@ config HEXDUMP
> config SPL_HEXDUMP
> bool "Enable hexdump in SPL"
> depends on HEXDUMP
I think it should depends on SPL alos
+ depends on SPL && HEXDUMP
> - default y
> help
> This enables functions for printing dumps of binary data in
> SPL.
> --
> 2.30.2
>
Regards
Patrick
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-27 9:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-24 15:35 [PATCH 1/1] lib: disable CONFIG_SPL_HEXDUMP by default Heinrich Schuchardt
2021-07-25 9:23 ` Michael Walle
2021-07-27 9:51 ` Patrick DELAUNAY
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).