From: "David S. Miller" <davem@redhat.com>
To: ultralinux@vger.kernel.org
Subject: Re: a bug in sparc/sparc64: test_bit()?
Date: Fri, 09 Feb 2001 16:40:11 +0000 [thread overview]
Message-ID: <marc-linux-ultrasparc-98173705530908@msgid-missing> (raw)
In-Reply-To: <marc-linux-ultrasparc-98172782300242@msgid-missing>
Ralf Liesegang writes:
> if i disassemble the function I see, that the CPU "loop" in:
>
> #define tasklet_unlock_wait(t) while (test_bit(TASKLET_STATE_RUN, &(t)->state))
>
> include/asm-sparc64/bitops.h: test_bit() do:
>
> return (1UL & (((__const__ long *) addr)[.....]
>
The correct fix is to put a memory barrier ("rmb()") in the
test_bit while loop of tasklet_unlock_wait.
Thanks for pointing this out.
Later,
David S. Miller
davem@redhat.com
-
To unsubscribe from this list: send the line "unsubscribe ultralinux" in
the body of a message to majordomo@vger.kernel.org
prev parent reply other threads:[~2001-02-09 16:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-09 14:08 a bug in sparc/sparc64: test_bit()? Ralf Liesegang
2001-02-09 16:40 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ultrasparc-98173705530908@msgid-missing \
--to=davem@redhat.com \
--cc=ultralinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).