* [PATCH] Mention systemd implementation of fsck
@ 2024-02-14 12:17 Stanislav Brabec
2024-02-14 14:23 ` Karel Zak
0 siblings, 1 reply; 4+ messages in thread
From: Stanislav Brabec @ 2024-02-14 12:17 UTC (permalink / raw
To: util-linux
systemd uses its own implementation of fsck with a slightly different
behavior (e. g. fsck -A checks noauto volumes, systemd-fsck does not).
Refer to it.
It is a complementar change to
https://github.com/systemd/systemd/commit/000680a68d.
Signed-off-by: Stanislav Brabec <sbrabec@suse.cz>
---
disk-utils/fsck.8.adoc | 4 ++++
sys-utils/fstab.5.adoc | 2 ++
2 files changed, 6 insertions(+)
diff --git a/disk-utils/fsck.8.adoc b/disk-utils/fsck.8.adoc
index 976e7ff08..4ba6f4cc1 100644
--- a/disk-utils/fsck.8.adoc
+++ b/disk-utils/fsck.8.adoc
@@ -151,6 +151,9 @@ enables libmount debug output.
_/etc/fstab_
+== NOTES
+*systemd* does not call *fsck -A*, but it has its own implementation
*systemd-fsck*(8).
+
== AUTHORS
mailto:tytso@mit.edu>[Theodore Ts'o],
@@ -169,6 +172,7 @@ mailto:kzak@redhat.com[Karel Zak]
*fsck.vfat*(8),
*fsck.xfs*(8),
*reiserfsck*(8)
+*systemd-fsck*(8)
include::man-common/bugreports.adoc[]
diff --git a/sys-utils/fstab.5.adoc b/sys-utils/fstab.5.adoc
index 1b972ef3b..0f12560e3 100644
--- a/sys-utils/fstab.5.adoc
+++ b/sys-utils/fstab.5.adoc
@@ -132,6 +132,8 @@ The proper way to read records from *fstab* is to
use the routines *getmntent*(3
The keyword *ignore* as a filesystem type (3rd field) is no longer
supported by the pure libmount based mount utility (since util-linux v2.22).
+This document describes handling of *fstab* by *util-linux* and
*libmount*. For *systemd*, read *systemd* documentation. There are
slight differences.
+
== HISTORY
The ancestor of this *fstab* file format appeared in 4.0BSD.
--
2.43.0
--
Best Regards / S pozdravem,
Stanislav Brabec
software developer
---------------------------------------------------------------------
SUSE LINUX, s. r. o. e-mail: sbrabec@suse.com
Křižíkova 148/34 (Corso IIa)
186 00 Praha 8-Karlín
Czech Republic http://www.suse.cz/
PGP: 830B 40D5 9E05 35D8 5E27 6FA3 717C 209F A04F CD76
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Mention systemd implementation of fsck
2024-02-14 12:17 [PATCH] Mention systemd implementation of fsck Stanislav Brabec
@ 2024-02-14 14:23 ` Karel Zak
2024-02-15 9:37 ` Karel Zak
0 siblings, 1 reply; 4+ messages in thread
From: Karel Zak @ 2024-02-14 14:23 UTC (permalink / raw
To: Stanislav Brabec; +Cc: util-linux
On Wed, Feb 14, 2024 at 01:17:46PM +0100, Stanislav Brabec wrote:
> systemd uses its own implementation of fsck with a slightly different
> behavior (e. g. fsck -A checks noauto volumes, systemd-fsck does not).
systemd calls fsck from util-linux, but a new instance (with -l) for each device.
It would be nice to be more explicit and explain it, because "it has its
own implementation" sounds like fsck from util-linux is completely out
of game :-)
> +== NOTES
> +*systemd* does not call *fsck -A*, but it has its own implementation
> *systemd-fsck*(8).
What about:
systemd does not invoke fsck -A to check all devices; instead, it
calls fsck individually for devices selected based on the logic
implemented in systemd-fsck.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Mention systemd implementation of fsck
2024-02-14 14:23 ` Karel Zak
@ 2024-02-15 9:37 ` Karel Zak
2024-02-17 20:01 ` Stanislav Brabec
0 siblings, 1 reply; 4+ messages in thread
From: Karel Zak @ 2024-02-15 9:37 UTC (permalink / raw
To: Stanislav Brabec; +Cc: util-linux
On Wed, Feb 14, 2024 at 03:23:45PM +0100, Karel Zak wrote:
> On Wed, Feb 14, 2024 at 01:17:46PM +0100, Stanislav Brabec wrote:
> > systemd uses its own implementation of fsck with a slightly different
> > behavior (e. g. fsck -A checks noauto volumes, systemd-fsck does not).
>
> systemd calls fsck from util-linux, but a new instance (with -l) for each device.
> It would be nice to be more explicit and explain it, because "it has its
> own implementation" sounds like fsck from util-linux is completely out
> of game :-)
>
> > +== NOTES
> > +*systemd* does not call *fsck -A*, but it has its own implementation
> > *systemd-fsck*(8).
>
> What about:
>
> systemd does not invoke fsck -A to check all devices; instead, it
> calls fsck individually for devices selected based on the logic
> implemented in systemd-fsck.
I had short discussion about it with Lennart, and he suggested not to
document anywhere systemd-fsck as it's private systemd stuff. I have
pushed to repository:
https://github.com/util-linux/util-linux/commit/9cb7b7671d903573d6c3b9d8112ec13953cdcdc6
Hope it good enough :-)
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Mention systemd implementation of fsck
2024-02-15 9:37 ` Karel Zak
@ 2024-02-17 20:01 ` Stanislav Brabec
0 siblings, 0 replies; 4+ messages in thread
From: Stanislav Brabec @ 2024-02-17 20:01 UTC (permalink / raw
To: Karel Zak; +Cc: util-linux
Dne 15. 02. 24 v 10:37 Karel Zak napsal(a):
> On Wed, Feb 14, 2024 at 03:23:45PM +0100, Karel Zak wrote:
>> What about:
>>
>> systemd does not invoke fsck -A to check all devices; instead, it
>> calls fsck individually for devices selected based on the logic
>> implemented in systemd-fsck.
> I had short discussion about it with Lennart, and he suggested not to
> document anywhere systemd-fsck as it's private systemd stuff. I have
> pushed to repository:
>
> https://github.com/util-linux/util-linux/commit/9cb7b7671d903573d6c3b9d8112ec13953cdcdc6
It sound clear. I didn't want to document any details of the
implementation in the third party package and it will not need an
update in case of an systemd change.
--
Best Regards / S pozdravem,
Stanislav Brabec
software developer
---------------------------------------------------------------------
SUSE LINUX, s. r. o. e-mail: sbrabec@suse.com
Křižíkova 148/34 (Corso IIa) tel: +420 284 084 060
186 00 Praha 8-Karlín fax: +420 284 084 001
Czech Republic http://www.suse.cz/
PGP: 830B 40D5 9E05 35D8 5E27 6FA3 717C 209F A04F CD76
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-17 20:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-14 12:17 [PATCH] Mention systemd implementation of fsck Stanislav Brabec
2024-02-14 14:23 ` Karel Zak
2024-02-15 9:37 ` Karel Zak
2024-02-17 20:01 ` Stanislav Brabec
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).