From: "John Stoffel" <john@stoffel.org>
To: David Howells <dhowells@redhat.com>
Cc: Christian Brauner <christian@brauner.io>,
Jeff Layton <jlayton@kernel.org>,
Gao Xiang <hsiangkao@linux.alibaba.com>,
Dominique Martinet <asmadeus@codewreck.org>,
Steve French <smfrench@gmail.com>,
Matthew Wilcox <willy@infradead.org>,
Marc Dionne <marc.dionne@auristor.com>,
Paulo Alcantara <pc@manguebit.com>,
Shyam Prasad N <sprasad@microsoft.com>,
Tom Talpey <tom@talpey.com>,
Eric Van Hensbergen <ericvh@kernel.org>,
Ilya Dryomov <idryomov@gmail.com>,
linux-cachefs@redhat.com, linux-afs@lists.infradead.org,
linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org,
ceph-devel@vger.kernel.org, v9fs@lists.linux.dev,
linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] netfs: Don't use certain internal folio_*() functions
Date: Wed, 10 Jan 2024 12:25:06 -0500 [thread overview]
Message-ID: <26014.54002.663705.978220@quad.stoffel.home> (raw)
In-Reply-To: <20240109180117.1669008-2-dhowells@redhat.com>
>>>>> "David" == David Howells <dhowells@redhat.com> writes:
> Filesystems should not be using folio->index not folio_index(folio)
^^^
I think you have an extra 'not' in all four patch comments.
> and folio-> mapping, not folio_mapping() or folio_file_mapping() in
> filesystem code.
next prev parent reply other threads:[~2024-01-10 17:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 18:01 [PATCH 0/4] netfs, afs, erofs, cifs: Don't use certain internal folio_*() functions David Howells
2024-01-09 18:01 ` [PATCH 1/4] netfs: " David Howells
2024-01-09 18:41 ` Jeff Layton
2024-01-10 17:25 ` John Stoffel [this message]
2024-01-09 18:01 ` [PATCH 2/4] afs: " David Howells
2024-01-09 18:01 ` [PATCH 3/4] erofs: " David Howells
2024-01-09 18:11 ` Gao Xiang
2024-01-09 18:01 ` [PATCH 4/4] cifs: " David Howells
2024-01-09 18:42 ` [PATCH 0/4] netfs, afs, erofs, " Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26014.54002.663705.978220@quad.stoffel.home \
--to=john@stoffel.org \
--cc=asmadeus@codewreck.org \
--cc=ceph-devel@vger.kernel.org \
--cc=christian@brauner.io \
--cc=dhowells@redhat.com \
--cc=ericvh@kernel.org \
--cc=hsiangkao@linux.alibaba.com \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-cachefs@redhat.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=netdev@vger.kernel.org \
--cc=pc@manguebit.com \
--cc=smfrench@gmail.com \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
--cc=v9fs@lists.linux.dev \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).