From: Eric Van Hensbergen <ericvh@kernel.org>
To: asmadeus@codewreck.org
Cc: v9fs@lists.linux.dev, linux_oss@crudebyte.com,
rminnich@gmail.com, lucho@ionkov.net
Subject: Re: [PATCH 7/9] fs/9p: rework qid2ino logic
Date: Mon, 8 Jan 2024 06:56:39 -0600 [thread overview]
Message-ID: <ZZvxB3u-yMypFI6c@FV7GG9FTHL> (raw)
In-Reply-To: <ZZvcT2__1syWHdbC@codewreck.org>
On Mon, Jan 08, 2024 at 08:28:15PM +0900, asmadeus@codewreck.org wrote:
> Eric Van Hensbergen wrote on Sat, Jan 06, 2024 at 02:11:14AM +0000:
> >
> > diff --git a/fs/9p/v9fs_vfs.h b/fs/9p/v9fs_vfs.h
> > index ad0310deb6c8..789e1188d5dc 100644
> > --- a/fs/9p/v9fs_vfs.h
> > +++ b/fs/9p/v9fs_vfs.h
> > @@ -43,7 +43,12 @@ void v9fs_free_inode(struct inode *inode);
> > int v9fs_init_inode(struct v9fs_session_info *v9ses,
> > struct inode *inode, umode_t mode, dev_t rdev);
> > void v9fs_evict_inode(struct inode *inode);
> > -ino_t v9fs_qid2ino(struct p9_qid *qid);
> > +#if (ULONG_MAX == 0xffffffffUL)
>
> The standard preprocessor condition in the kernel for this is checking
> BITS_PER_LONG, e.g.
> include/asm-generic/bitops/fls64.h
> 18:#if BITS_PER_LONG == 32
> 26:#elif BITS_PER_LONG == 64
> 33:#else
> 34:#error BITS_PER_LONG not 32 or 64
> 35:#endif
>
Thanks for that, will update to be consistent with rest of kernel.
> > -
> > +
>
> stray white space?
>
oops, will fix.
> > @@ -428,7 +426,6 @@ static struct inode *v9fs_qid_iget(struct super_block *sb,
> > * FIXME!! we may need support for stale inodes
> > * later.
> > */
> > - inode->i_ino = i_ino;
>
> This is gone, but v9fs_qid_iget_dotl() still sets i_ino -- didn't check
> which is needed but we probably want to stay coherent between the two.
>
Good catch, deleted it from .L (and later here but in a different patch)
because its largely vestigial since this gets set in iget_locked anyways.
Will fix up to be more consistent.
-eric
next prev parent reply other threads:[~2024-01-08 12:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-06 2:11 [PATCH 0/9] fs/9p: simplify inode lookup operations Eric Van Hensbergen
2024-01-06 2:11 ` [PATCH 1/9] fs/9p: future-proof qid2ino 32-bit support Eric Van Hensbergen
2024-01-06 4:01 ` Eric Van Hensbergen
2024-01-06 2:11 ` [PATCH 2/9] fs/9p: switch vfsmount to use v9fs_get_new_inode Eric Van Hensbergen
2024-01-06 2:11 ` [PATCH 3/9] fs/9p: convert mkdir to use get_new_inode Eric Van Hensbergen
2024-01-06 2:11 ` [PATCH 4/9] fs/9p: remove walk and inode allocation from symlink Eric Van Hensbergen
2024-01-06 2:11 ` [PATCH 5/9] fs/9p: Eliminate redundant non-cache path in mknod Eric Van Hensbergen
2024-01-06 2:11 ` [PATCH 6/9] fs/9p: Eliminate now unused v9fs_get_inode Eric Van Hensbergen
2024-01-06 2:11 ` [PATCH 7/9] fs/9p: rework qid2ino logic Eric Van Hensbergen
2024-01-08 11:28 ` asmadeus
2024-01-08 12:56 ` Eric Van Hensbergen [this message]
2024-01-06 2:11 ` [PATCH 8/9] fs/9p: simplify iget path to remove unnecessary paths Eric Van Hensbergen
2024-01-06 2:11 ` [PATCH 9/9] fs/9p: Further simplify inode lookup Eric Van Hensbergen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZvxB3u-yMypFI6c@FV7GG9FTHL \
--to=ericvh@kernel.org \
--cc=asmadeus@codewreck.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=rminnich@gmail.com \
--cc=v9fs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).