From: Parav Pandit <parav@nvidia.com>
To: <virtio-comment@lists.oasis-open.org>, <mst@redhat.com>,
<cohuck@redhat.com>
Cc: <sburla@marvell.com>, <shahafs@nvidia.com>,
<si-wei.liu@oracle.com>, <xuanzhuo@linux.alibaba.com>,
Parav Pandit <parav@nvidia.com>
Subject: [virtio-comment] [PATCH v1 0/7] virtio-net: Support flow filter for receive packets
Date: Sat, 7 Oct 2023 08:14:36 +0300 [thread overview]
Message-ID: <20231007051443.460148-1-parav@nvidia.com> (raw)
Summary:
========
This series improves virtio net receive packet steering to forward/steer
packets to specific RQ.
This basic functionality will enable Linux ethtool steering, Accelerated
receive flow steering (ARFS) as starting point, and more use cases in
future.
Problem statement:
==================
Currently packet allow/drop interface has few limitations.
1. Driver cannot add or delete an individual entry for mac and vlan.
2. Driver cannot select mac+vlan combination for which
to allow/drop packet.
3. Driver cannot not set other commonly used packet match fields
such as IP header fields, TCP, UDP, SCP header fields.
4. Driver cannot steer specific packets based on the match
fields to specific receiveq.
5. Driver do not have multiple or dedicated virtqueues to
perform flow filter requests in accelerated manner in
the device.
Solution:
=========
Flow filter as generic framework to overcome above limitations.
Overview:
=========
A flow filter defines the flow based on one or more match fields
of the packet, defines an action like drop/forward to RQ.
The flow filters are organized in flow filter groups so that they
can be ordered when multiple applications wants to use it.
Flow filters requests can be transported via control vq or dedicated
flow filter virtqueue so that it does not get intermixed with other
slow operations of cvq.
Flow filter requirements addressed by this series is worked by virtio community at
Fixes: https://github.com/oasis-tcs/virtio-spec/issues/179
This series utilizes enhancements proposed in [2] and [3].
It uses updated control vq command format from [3].
It uses new _DYNAMIC feature to create queues when needed and
saves guest and device resources.
[1] https://lists.oasis-open.org/archives/virtio-comment/202308/msg00263.html
[2] https://lists.oasis-open.org/archives/virtio-comment/202309/msg00236.html
[3] https://lists.oasis-open.org/archives/virtio-comment/202309/msg00227.html
Patch summary:
==============
patch-1 adds theory of operation description for flow filter
patch-2 adds device capabilities cvq commands
patch-3 adds group add/delete commands
patch-4 adds transport set command
patch-5 adds packet match fields and values
patch-6 adds flow filter requests to transport via vq
patch-7 adds device and driver requirements
Please review.
Changelog:
==========
v0->v1:
- addressed comments from Satananda
- added device requirement to return non zero value in fields_bmap
- added device requirement to not repeat filter type in response
- added driver requirement to order filter match field as it
appears in the packet
- added device requirement to fail group delete command on existing
flow entries
- added mask field in the type to indicate supported mask by device
and also in later patch to use it to indicate mask on adding
flow filter. As a result removed the mask_supported capability
field
Parav Pandit (7):
virtio-net: Add theory of operation for flow filter
virtio-net: Add flow filter capabilities read commands
virtio-net: Add flow filter group life cycle commands
virtio-net: Add flow filter transport set command
virtio-net: Add flow filter match values
virtio-net: Add flow filter requests
virtio-net: Add flow filter device and driver requirements
device-types/net/description.tex | 687 ++++++++++++++++++++++++++++++-
1 file changed, 686 insertions(+), 1 deletion(-)
--
2.34.1
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
next reply other threads:[~2023-10-07 5:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-07 5:14 Parav Pandit [this message]
2023-10-07 5:14 ` [virtio-comment] [PATCH v1 1/7] virtio-net: Add theory of operation for flow filter Parav Pandit
2023-10-19 7:09 ` Heng Qi
2023-10-19 9:14 ` Parav Pandit
2023-10-07 5:14 ` [virtio-comment] [PATCH v1 2/7] virtio-net: Add flow filter capabilities read commands Parav Pandit
2023-10-15 23:40 ` [virtio-comment] RE: [EXT] " Satananda Burla
2023-10-16 16:35 ` Parav Pandit
2023-10-16 21:11 ` Satananda Burla
2023-10-20 12:34 ` Parav Pandit
2023-10-19 7:13 ` [virtio-comment] " Heng Qi
2023-10-19 9:08 ` Parav Pandit
2023-10-07 5:14 ` [virtio-comment] [PATCH v1 3/7] virtio-net: Add flow filter group life cycle commands Parav Pandit
2023-10-07 5:14 ` [virtio-comment] [PATCH v1 4/7] virtio-net: Add flow filter transport set command Parav Pandit
2023-10-07 5:14 ` [virtio-comment] [PATCH v1 5/7] virtio-net: Add flow filter match values Parav Pandit
2023-10-07 5:14 ` [virtio-comment] [PATCH v1 6/7] virtio-net: Add flow filter requests Parav Pandit
2023-10-15 23:40 ` [virtio-comment] RE: [EXT] " Satananda Burla
2023-10-16 16:55 ` Parav Pandit
2023-10-20 12:35 ` Parav Pandit
2023-10-07 5:14 ` [virtio-comment] [PATCH v1 7/7] virtio-net: Add flow filter device and driver requirements Parav Pandit
2023-10-15 23:40 ` [virtio-comment] RE: [EXT] " Satananda Burla
2023-10-16 16:54 ` Parav Pandit
2023-10-16 20:31 ` Satananda Burla
2023-10-19 6:56 ` [virtio-comment] " Heng Qi
2023-10-19 6:51 ` [virtio-comment] [PATCH v1 0/7] virtio-net: Support flow filter for receive packets Heng Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231007051443.460148-1-parav@nvidia.com \
--to=parav@nvidia.com \
--cc=cohuck@redhat.com \
--cc=mst@redhat.com \
--cc=sburla@marvell.com \
--cc=shahafs@nvidia.com \
--cc=si-wei.liu@oracle.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).