From: Heng Qi <hengqi@linux.alibaba.com>
To: "Michael S. Tsirkin" <mst@redhat.com>, Parav Pandit <parav@nvidia.com>
Cc: "virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
Jason Wang <jasowang@redhat.com>,
Yuri Benditovich <yuri.benditovich@daynix.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
Cornelia Huck <cohuck@redhat.com>
Subject: Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v18] virtio-net: support inner header hash
Date: Thu, 22 Jun 2023 08:46:14 +0800 [thread overview]
Message-ID: <8629e939-74aa-5d4d-4ff5-42e34b53ad50@linux.alibaba.com> (raw)
In-Reply-To: <20230621153237-mutt-send-email-mst@kernel.org>
在 2023/6/22 上午3:35, Michael S. Tsirkin 写道:
> On Wed, Jun 21, 2023 at 07:28:33PM +0000, Parav Pandit wrote:
>>
>>> From: Michael S. Tsirkin <mst@redhat.com>
>>> Sent: Wednesday, June 21, 2023 3:26 PM
>>>
>>> On Wed, Jun 21, 2023 at 05:52:28PM +0000, Parav Pandit wrote:
>>>>> From: Heng Qi <hengqi@linux.alibaba.com>
>>>>> Sent: Wednesday, June 21, 2023 12:46 PM
>>>>
>>>>> SET carries an additional 32 bits of information. But if you think
>>>>> this will make the overall structure more concise, I'm ok.
>>>>>
>>>> If it is placed in single structure than it needs to be reworded to remove WO
>>> or RO notion.
>>>
>>> Not really. all of structure is RO and WO.
>>>
>> For the device, what is the meaning of driver writing supported_tunnel_types in SET command?
>> Ignore? It doesn't make sense to pass something to ignore.
> It can be helpful for debugging. E.g. if driver sets
> a bit that device does not recognize, it can figure
> out that driver has it set in supported mask.
> Or if it seems like a waste we can just ask drivers to
> put 0 there, works for me too.
For the SET command, it is a bit strange to have the driver write
support_hash_tunnel_types to the device.
'supported' is the capability of the device, 'enabled' is the capability
of the driver.
The driver should be read-only to 'supported', the driver should not try
to write it.
Thanks.
>
>
>> Two structures are cleaner.
> Frankly what's cleaner is what RSS is doing, supported mask in config
> space. Was this discussed in some version? I don't remember.
>
>>>> This also requires additional sw to indicate dma attributes to be RW when
>>> mapping this area.
>>>> And extra text to indicate that supported_hash_tunnel_types to be ignored
>>> on set command.
>>>> Two structures are more cleaner serving its purpose.
>>> No because all of structure is RO or WO.
>> This publicly archived list offers a means to provide input to the
>> OASIS Virtual I/O Device (VIRTIO) TC.
>>
>> In order to verify user consent to the Feedback License terms and
>> to minimize spam in the list archive, subscription is required
>> before posting.
>>
>> Subscribe: virtio-comment-subscribe@lists.oasis-open.org
>> Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
>> List help: virtio-comment-help@lists.oasis-open.org
>> List archive: https://lists.oasis-open.org/archives/virtio-comment/
>> Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
>> List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
>> Committee: https://www.oasis-open.org/committees/virtio/
>> Join OASIS: https://www.oasis-open.org/join/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
> For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2023-06-22 0:46 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 13:50 [virtio-dev] [PATCH v18] virtio-net: support inner header hash Heng Qi
2023-06-21 15:38 ` [virtio-dev] " Michael S. Tsirkin
2023-06-21 16:46 ` [virtio-dev] Re: [virtio-comment] " Heng Qi
2023-06-21 17:52 ` [virtio-dev] " Parav Pandit
2023-06-21 19:25 ` [virtio-dev] " Michael S. Tsirkin
2023-06-21 19:28 ` [virtio-dev] " Parav Pandit
2023-06-21 19:35 ` [virtio-dev] " Michael S. Tsirkin
2023-06-21 19:39 ` [virtio-dev] " Parav Pandit
2023-06-21 19:45 ` [virtio-dev] " Michael S. Tsirkin
2023-06-22 0:46 ` Heng Qi [this message]
2023-06-21 19:32 ` Michael S. Tsirkin
2023-06-21 19:37 ` [virtio-dev] " Parav Pandit
2023-06-21 20:16 ` [virtio-dev] " Michael S. Tsirkin
2023-06-21 20:24 ` [virtio-dev] " Parav Pandit
2023-06-21 20:37 ` [virtio-dev] " Michael S. Tsirkin
2023-06-21 20:52 ` [virtio-dev] " Parav Pandit
2023-06-22 0:59 ` Heng Qi
2023-06-22 1:04 ` Parav Pandit
2023-06-22 1:17 ` Heng Qi
2023-06-22 6:23 ` [virtio-dev] " Michael S. Tsirkin
2023-06-22 12:32 ` [virtio-dev] " Parav Pandit
2023-06-22 13:42 ` [virtio-dev] " Heng Qi
2023-06-22 14:27 ` [virtio-dev] " Parav Pandit
2023-06-22 16:46 ` [virtio-dev] " Michael S. Tsirkin
2023-06-22 16:54 ` [virtio-dev] " Parav Pandit
2023-06-22 17:03 ` [virtio-dev] " Michael S. Tsirkin
2023-06-22 17:11 ` [virtio-dev] " Parav Pandit
2023-06-22 17:28 ` [virtio-dev] " Michael S. Tsirkin
2023-06-22 17:58 ` [virtio-dev] " Parav Pandit
2023-06-28 10:41 ` [virtio-dev] " Michael S. Tsirkin
2023-06-28 16:46 ` [virtio-dev] " Parav Pandit
2023-06-28 17:08 ` [virtio-dev] " Michael S. Tsirkin
2023-06-22 16:28 ` Michael S. Tsirkin
2023-06-22 16:42 ` [virtio-dev] " Parav Pandit
2023-06-22 16:54 ` [virtio-dev] " Michael S. Tsirkin
2023-06-22 17:04 ` Parav Pandit
2023-06-22 17:14 ` Michael S. Tsirkin
2023-06-22 17:20 ` Parav Pandit
2023-06-22 17:43 ` Michael S. Tsirkin
2023-06-22 18:12 ` Parav Pandit
2023-06-22 18:36 ` Michael S. Tsirkin
2023-06-22 17:11 ` Michael S. Tsirkin
2023-06-22 17:15 ` [virtio-dev] " Parav Pandit
2023-06-22 17:37 ` [virtio-dev] " Michael S. Tsirkin
2023-06-22 17:51 ` Parav Pandit
2023-06-22 18:11 ` Michael S. Tsirkin
2023-06-22 18:17 ` Parav Pandit
2023-06-22 18:40 ` Michael S. Tsirkin
2023-06-22 18:50 ` [virtio-dev] RE: [virtio-comment] " Parav Pandit
2023-06-22 19:02 ` [virtio-dev] " Michael S. Tsirkin
2023-06-22 20:27 ` [virtio-dev] " Parav Pandit
2023-06-28 10:47 ` [virtio-dev] " Michael S. Tsirkin
2023-06-22 0:41 ` Heng Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8629e939-74aa-5d4d-4ff5-42e34b53ad50@linux.alibaba.com \
--to=hengqi@linux.alibaba.com \
--cc=cohuck@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=parav@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=xuanzhuo@linux.alibaba.com \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).