From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Jonathan Corbet <corbet@lwn.net>
Cc: workflows@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Submitting Co-Author <sub@coauthor.example.org>
Subject: [PATCH] docs: submitting-patches: Introduce Test: tag
Date: Sat, 07 Oct 2023 02:43:08 +0200 [thread overview]
Message-ID: <20231007-topic-test_tag-v1-1-513cd9e577ed@linaro.org> (raw)
Currently, we blindly trust the submitters that they both compiled their
code at all, tested it on a relevant device, and have done so in a manner
that made sense for a given changeset.
If at least two of these three things were always true, the review
workflow would be much more exciting.
Introduce a new Test: tag to help submitters express the way the patch
was tested, making it easier to understand for reviewers and maintainers
whether it was tested, and if so, whether that test was sufficient.
I originally found something like this on Google's Android kernel repos
and loved the concept.
Test: make htmldocs and manual examination
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
Documentation/process/submitting-patches.rst | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
index 3fcfa029c9b3..c3fda5743ca7 100644
--- a/Documentation/process/submitting-patches.rst
+++ b/Documentation/process/submitting-patches.rst
@@ -522,7 +522,7 @@ Example of a patch submitted by a Co-developed-by: author::
Signed-off-by: Submitting Co-Author <sub@coauthor.example.org>
-Using Reported-by:, Tested-by:, Reviewed-by:, Suggested-by: and Fixes:
+Using informative tags:
----------------------------------------------------------------------
The Reported-by tag gives credit to people who find bugs and report them and it
@@ -600,6 +600,22 @@ process nor the requirement to Cc: stable@vger.kernel.org on all stable
patch candidates. For more information, please read
Documentation/process/stable-kernel-rules.rst.
+A Test: tag confirms that the patch was actually tested by the submitter and
+helps reviewers determine whether the testing procedure made sense for a given
+changeset. The latter in particular, may bring attention to errors in the
+testing procedure and prompt a more in-depth examination of a patch.
+
+Commonly, ``Test: Smoke test on [device name]`` may be used to signify that:
+
+ (a) The kernel compiled successfully with the default defconfig.
+
+ (b) The device has successfully booted the image from point (a), with
+ no apparent loss in functionality compared to the state before this
+ patch was applied.
+
+ (c) The submitter believes in good faith, that such simple test is
+ enough, given the scope of the patch.
+
.. _the_canonical_patch_format:
The canonical patch format
---
base-commit: 0f0fe5040de5e5fd9b040672e37725b046e312f0
change-id: 20231007-topic-test_tag-72bca62617f9
Best regards,
--
Konrad Dybcio <konrad.dybcio@linaro.org>
next reply other threads:[~2023-10-07 0:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-07 0:43 Konrad Dybcio [this message]
2023-10-07 12:57 ` [PATCH] docs: submitting-patches: Introduce Test: tag Jonathan Corbet
2023-10-08 17:18 ` Geert Uytterhoeven
2023-10-09 10:14 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231007-topic-test_tag-v1-1-513cd9e577ed@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=andersson@kernel.org \
--cc=corbet@lwn.net \
--cc=dmitry.baryshkov@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=sub@coauthor.example.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).