Workflows Archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Jonathan Corbet <corbet@lwn.net>
Cc: Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
	workflows@vger.kernel.org, ast@kernel.org,
	linux-doc@vger.kernel.org
Subject: Re: Simple analytics for docs.kernel.org and patchwork, please?
Date: Mon, 26 Feb 2024 14:52:51 -0800	[thread overview]
Message-ID: <20240226145251.6335b6f6@kernel.org> (raw)
In-Reply-To: <875xyb2e18.fsf@meer.lwn.net>

On Mon, 26 Feb 2024 12:58:43 -0700 Jonathan Corbet wrote:
> Jakub Kicinski <kuba@kernel.org> writes:
> > On Mon, 26 Feb 2024 14:24:39 -0500 Konstantin Ryabitsev wrote:  
> >> In general, my previous experience enabling libravatar on git.kernel.org has
> >> taught me that many very vocal people *really* don't like to have any kind of
> >> statistics gathered about them. However, if it's just for docs.kernel.org,
> >> then I don't think I have specific objections.
> >> 
> >> That said, I would need help turning this on -- if someone can pass me along a
> >> Sphinx configuration option that I can enable during build time, then I'll be
> >> happy to add it to our build jobs.  
> >
> > Excellent :)
> >
> > Let me CC linux-doc in case someone can tell us how to hook things in.  
> 
> It's probably not just a configuration option.  I suspect that this will
> need to be done either by editing the templates or with a little
> extension.  Either could require adding this support to the kernel repo,
> which might raise some eyebrows.

FWIW I tried poking around to insert "script_files" into conf.py,
because the RTD template does seem to have:

      {%- for scriptfile in script_files %}
        {{ js_tag(scriptfile) }}
      {%- endfor %}

But I only managed to add a pure "include" with just the 'src'
attribute on the <script> node, like:

	<script src="../../cabbage.js"></script>

We also need to set 'defer' and "data-domain="docs.kernel.org"'.

      reply	other threads:[~2024-02-26 22:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-23 16:31 Simple analytics for docs.kernel.org and patchwork, please? Jakub Kicinski
2024-02-23 17:14 ` Mauro Carvalho Chehab
2024-02-23 17:49 ` Jonathan Corbet
2024-02-23 20:02   ` Jakub Kicinski
2024-02-26 19:06 ` Jakub Kicinski
2024-02-26 19:24 ` Konstantin Ryabitsev
2024-02-26 19:43   ` Jakub Kicinski
2024-02-26 19:58     ` Jonathan Corbet
2024-02-26 22:52       ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240226145251.6335b6f6@kernel.org \
    --to=kuba@kernel.org \
    --cc=ast@kernel.org \
    --cc=corbet@lwn.net \
    --cc=konstantin@linuxfoundation.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).