From: Guru Das Srinagesh <quic_gurus@quicinc.com>
To: Pavan Kondeti <quic_pkondeti@quicinc.com>
Cc: Guru Das Srinagesh <quic_gurus@quicinc.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
Nicolas Schier <nicolas@fjasle.eu>,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
Kees Cook <keescook@chromium.org>,
Bjorn Andersson <andersson@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>,
Will Deacon <will@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-kernel@vger.kernel.org>, <kernel@quicinc.com>,
<workflows@vger.kernel.org>, <tools@linux.kernel.org>,
<devicetree@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-pm@vger.kernel.org>
Subject: Re: [PATCH v3 1/1] scripts: Add add-maintainer.py
Date: Wed, 27 Sep 2023 15:47:16 -0700 [thread overview]
Message-ID: <ZRSw9EGuYEpZC6GE@quicinc.com> (raw)
In-Reply-To: <d0711242-df00-45c7-962f-841f7cefa7e3@quicinc.com>
On Sep 26 2023 17:32, Pavan Kondeti wrote:
> On Sat, Aug 26, 2023 at 01:07:42AM -0700, Guru Das Srinagesh wrote:
> > +def gather_maintainers_of_file(patch_file):
> > + all_entities_of_patch = dict()
> > +
> > + # Run get_maintainer.pl on patch file
> > + logging.info("GET: Patch: {}".format(os.path.basename(patch_file)))
> > + cmd = ['scripts/get_maintainer.pl']
> > + cmd.extend([patch_file])
> > +
> > + try:
> > + p = subprocess.run(cmd, stdout=subprocess.PIPE, check=True)
> > + except:
> > + sys.exit(1)
> > +
> > + logging.debug("\n{}".format(p.stdout.decode()))
> > +
> > + entries = p.stdout.decode().splitlines()
> > +
> > + maintainers = []
> > + lists = []
> > + others = []
> > +
> > + for entry in entries:
> > + entity = entry.split('(')[0].strip()
> > + if any(role in entry for role in ["maintainer", "reviewer"]):
> > + maintainers.append(entity)
> > + elif "list" in entry:
> > + lists.append(entity)
> > + else:
> > + others.append(entity)
> > +
> > + all_entities_of_patch["maintainers"] = set(maintainers)
> > + all_entities_of_patch["lists"] = set(lists)
> > + all_entities_of_patch["others"] = set(others)
> > +
> > + return all_entities_of_patch
> > +
>
> FYI, there are couple of issues found while playing around.
Thanks for testing this out :) I am no longer working on this due to pushback
from the maintainers in favour of b4.
>
> - Some entries in MAINTAINERS could be "supporter"
This was intentional - I didn't want to include "supporter"s.
> - When names contain ("company"), the script fails to extract name.
Interesting... I had not tested this out.
In any case, I am not devoting resources to work on this unless I see some
interest from maintainers, which, as it stands currently, is nil.
Thanks for the support, Pavan.
Guru Das.
prev parent reply other threads:[~2023-09-27 22:48 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-26 8:07 [PATCH v3 0/1] Add add-maintainer.py script Guru Das Srinagesh
2023-08-26 8:07 ` [PATCH v3 1/1] scripts: Add add-maintainer.py Guru Das Srinagesh
2023-08-27 16:44 ` Randy Dunlap
2023-08-28 16:45 ` Guru Das Srinagesh
2023-08-28 8:14 ` Jani Nikula
2023-08-28 13:35 ` Bjorn Andersson
2023-08-28 13:48 ` Geert Uytterhoeven
2023-08-28 15:14 ` Vlastimil Babka
2023-08-28 15:23 ` Krzysztof Kozlowski
2023-08-28 16:50 ` Bjorn Andersson
2023-08-29 7:38 ` Jani Nikula
2023-08-28 16:50 ` Guru Das Srinagesh
2023-08-28 8:21 ` Krzysztof Kozlowski
2023-08-28 17:56 ` Guru Das Srinagesh
2023-08-28 17:59 ` Krzysztof Kozlowski
2023-08-28 19:41 ` Mark Brown
2023-08-28 19:45 ` Krzysztof Kozlowski
2023-08-29 23:16 ` Guru Das Srinagesh
2023-08-30 7:11 ` Krzysztof Kozlowski
2023-08-30 11:22 ` Mark Brown
2023-08-30 14:16 ` Jeff Johnson
2023-09-27 4:51 ` Pavan Kondeti
2023-09-27 22:44 ` Guru Das Srinagesh
2023-09-26 12:02 ` Pavan Kondeti
2023-09-27 4:54 ` Pavan Kondeti
2023-09-27 22:47 ` Guru Das Srinagesh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRSw9EGuYEpZC6GE@quicinc.com \
--to=quic_gurus@quicinc.com \
--cc=akpm@linux-foundation.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=kernel@quicinc.com \
--cc=konstantin@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nicolas@fjasle.eu \
--cc=quic_pkondeti@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=tools@linux.kernel.org \
--cc=will@kernel.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).