From: Jesper Dangaard Brouer <jbrouer@redhat.com>
To: Magnus Karlsson <magnus.karlsson@gmail.com>,
Jesper Dangaard Brouer <jbrouer@redhat.com>
Cc: brouer@redhat.com, "Karlsson, Magnus" <magnus.karlsson@intel.com>,
"Björn Töpel" <bjorn@kernel.org>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Network Development" <netdev@vger.kernel.org>,
"Fijalkowski, Maciej" <maciej.fijalkowski@intel.com>,
"Jonathan Lemon" <jonathan.lemon@gmail.com>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
bpf <bpf@vger.kernel.org>, Xdp <xdp-newbies@vger.kernel.org>
Subject: Re: [PATCH bpf-next] selftests, bpf: remove AF_XDP samples
Date: Mon, 4 Jul 2022 20:44:06 +0200 [thread overview]
Message-ID: <263b8398-01fa-a8df-09d9-69bd8e49bc1e@redhat.com> (raw)
In-Reply-To: <CAJ8uoz2KmpVf7nkJXUsHhmOtS2Td+rMOX8-PRqzz9QxJB-tZ3g@mail.gmail.com>
On 30/06/2022 16.20, Magnus Karlsson wrote:
> On Thu, Jun 30, 2022 at 3:44 PM Jesper Dangaard Brouer
> <jbrouer@redhat.com> wrote:
>>
>>
>> On 30/06/2022 11.37, Magnus Karlsson wrote:
>>> From: Magnus Karlsson <magnus.karlsson@intel.com>
>>>
>>> Remove the AF_XDP samples from samples/bpf as they are dependent on
>>> the AF_XDP support in libbpf. This support has now been removed in the
>>> 1.0 release, so these samples cannot be compiled anymore. Please start
>>> to use libxdp instead. It is backwards compatible with the AF_XDP
>>> support that was offered in libbpf. New samples can be found in the
>>> various xdp-project repositories connected to libxdp and by googling.
>>>
>>> Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
>>
>> Will you (or Maciej) be submitting these samples to XDP-tools[1] which
>> is the current home for libxdp or maybe BPF-examples[2] ?
>>
>> [1] https://github.com/xdp-project/xdp-tools
>> [2] https://github.com/xdp-project/bpf-examples
>>
>> I know Toke is ready to take over maintaining these, but we will
>> appreciate someone to open a PR with this code...
>>
>>> ---
>>> MAINTAINERS | 2 -
>>> samples/bpf/Makefile | 9 -
>>> samples/bpf/xdpsock.h | 19 -
>>> samples/bpf/xdpsock_ctrl_proc.c | 190 ---
>>> samples/bpf/xdpsock_kern.c | 24 -
>>> samples/bpf/xdpsock_user.c | 2019 -------------------------------
>>> samples/bpf/xsk_fwd.c | 1085 -----------------
>>
>> The code in samples/bpf/xsk_fwd.c is interesting, because it contains a
>> buffer memory manager, something I've seen people struggle with getting
>> right and performant (at the same time).
>
> I can push xsk_fwd to BPF-examples. Though I do think that xdpsock has
> become way too big to serve as a sample. It slowly turned into a catch
> all demonstrating every single feature of AF_XDP. We need a minimal
> example and then likely other samples for other features that should
> be demoed. So I suggest that xdpsock dies here and we start over with
> something minimal and use xsk_fwd for the forwarding and mempool
> example.
I trust that we in bpf-examples[0] will see a PR with this from
you/Intel, so:
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
> Toke, I think you told me at Recipes in Paris that someone from RedHat
> was working on an example. Did I remember correctly?
>
>> You can get my ACK if someone commits to port this to [1] or [2], or a
>> 3rd place that have someone what will maintain this in the future.
>>
[0] https://github.com/xdp-project/bpf-examples/
prev parent reply other threads:[~2022-07-04 18:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220630093717.8664-1-magnus.karlsson@gmail.com>
2022-06-30 13:44 ` [PATCH bpf-next] selftests, bpf: remove AF_XDP samples Jesper Dangaard Brouer
2022-06-30 14:20 ` Magnus Karlsson
2022-07-01 12:15 ` Toke Høiland-Jørgensen
2022-07-01 13:04 ` Srivats P
2022-07-01 13:16 ` Magnus Karlsson
2022-07-04 18:44 ` Jesper Dangaard Brouer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=263b8398-01fa-a8df-09d9-69bd8e49bc1e@redhat.com \
--to=jbrouer@redhat.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=hawk@kernel.org \
--cc=jonathan.lemon@gmail.com \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@gmail.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
--cc=xdp-newbies@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).