XDP-Newbies Archive mirror
 help / color / mirror / Atom feed
From: Alasdair McWilliam <alasdair.mcwilliam@outlook.com>
To: Magnus Karlsson <magnus.karlsson@gmail.com>
Cc: "Fijalkowski, Maciej" <maciej.fijalkowski@intel.com>,
	Xdp <xdp-newbies@vger.kernel.org>
Subject: Re: XSK + ZC, shared UMEM and multiple Fill/Completion queues - broken?
Date: Wed, 10 Aug 2022 14:06:21 +0000	[thread overview]
Message-ID: <9C103784-4C86-406C-ADB2-0667CA481BD4@outlook.com> (raw)
In-Reply-To: <CAJ8uoz0+C+2V1bFeSd5_NMGYoDSOfYf8uXJac41oqtdfxBo6vw@mail.gmail.com>


> 
> OK, I believe I have found the problem and have produced a fix for it.
> As usual, it is something simple and stupid, sigh. I will post a patch
> here tomorrow. Would you be able to test it and see if it fixes the
> problem with corrupted packets in your app? If it does, then I will
> post the patch on the netdev mailing list. Just note that even if this
> fixes this, there is still your RSS problem. Maciej is looking into
> that. You were also reporting stalls, which we should examine if they
> still occur after fixing the corrupted packets and the RSS problem.
> 
> /Magnus

That’s awesome - thank you! Happy to test - just fire it over.

We’ve observed “differing” behaviour, and we did wonder if there were two overlapping issues. Unfortunately we could not identify a specific order of operation to trigger behaviour A (e.g. queue 1+ not working) vs behaviour B (e.g. queue stalls). Have you observed alternating behaviour with xdpsock_multi?

Kind regards
Alasdair


      reply	other threads:[~2022-08-10 14:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-09 14:25 XSK + ZC, shared UMEM and multiple Fill/Completion queues - broken? Alasdair McWilliam
2022-08-09 14:43 ` Magnus Karlsson
2022-08-09 14:50   ` Alasdair McWilliam
2022-08-09 14:58     ` Magnus Karlsson
2022-08-09 15:12       ` Alasdair McWilliam
2022-08-10 13:16         ` Magnus Karlsson
2022-08-10 14:06           ` Alasdair McWilliam [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9C103784-4C86-406C-ADB2-0667CA481BD4@outlook.com \
    --to=alasdair.mcwilliam@outlook.com \
    --cc=maciej.fijalkowski@intel.com \
    --cc=magnus.karlsson@gmail.com \
    --cc=xdp-newbies@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).