* [PATCH 3.4 165/172] config: Enable NEED_DMA_MAP_STATE by default when SWIOTLB is selected
[not found] <1434443587-4599-1-git-send-email-lizf@kernel.org>
@ 2015-06-16 8:36 ` lizf
2015-06-16 15:13 ` [PATCH 3.4 000/172] 3.4.108-rc1 review Ian Campbell
[not found] ` <1434467619.13744.221.camel@citrix.com>
2 siblings, 0 replies; 4+ messages in thread
From: lizf @ 2015-06-16 8:36 UTC (permalink / raw
To: stable
Cc: linux-kernel, Konrad Rzeszutek Wilk, Borislav Petkov,
H. Peter Anvin, Linus Torvalds, Michael Chan, Thomas Gleixner,
boris.ostrovsky, cascardo, david.vrabel, sanjeevb, siva.kallam,
vyasevich, xen-devel, Ingo Molnar, Ben Hutchings, Zefan Li
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
3.4.108-rc1 review patch. If anyone has any objections, please let me know.
------------------
commit a6dfa128ce5c414ab46b1d690f7a1b8decb8526d upstream.
A huge amount of NIC drivers use the DMA API, however if
compiled under 32-bit an very important part of the DMA API can
be ommitted leading to the drivers not working at all
(especially if used with 'swiotlb=force iommu=soft').
As Prashant Sreedharan explains it: "the driver [tg3] uses
DEFINE_DMA_UNMAP_ADDR(), dma_unmap_addr_set() to keep a copy of
the dma "mapping" and dma_unmap_addr() to get the "mapping"
value. On most of the platforms this is a no-op, but ... with
"iommu=soft and swiotlb=force" this house keeping is required,
... otherwise we pass 0 while calling pci_unmap_/pci_dma_sync_
instead of the DMA address."
As such enable this even when using 32-bit kernels.
Reported-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Acked-by: David S. Miller <davem@davemloft.net>
Acked-by: Prashant Sreedharan <prashant@broadcom.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Michael Chan <mchan@broadcom.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: boris.ostrovsky@oracle.com
Cc: cascardo@linux.vnet.ibm.com
Cc: david.vrabel@citrix.com
Cc: sanjeevb@broadcom.com
Cc: siva.kallam@broadcom.com
Cc: vyasevich@gmail.com
Cc: xen-devel@lists.xensource.com
Link: http://lkml.kernel.org/r/20150417190448.GA9462@l.oracle.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Ben Hutchings <ben@decadent.org.uk>
[lizf: Backported to 3.4: adjust context]
Signed-off-by: Zefan Li <lizefan@huawei.com>
---
arch/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 917c109..eda8cb9 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -129,7 +129,7 @@ config SBUS
bool
config NEED_DMA_MAP_STATE
- def_bool (X86_64 || INTEL_IOMMU || DMA_API_DEBUG)
+ def_bool (X86_64 || INTEL_IOMMU || DMA_API_DEBUG || SWIOTLB)
config NEED_SG_DMA_LENGTH
def_bool y
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 3.4 000/172] 3.4.108-rc1 review
[not found] <1434443587-4599-1-git-send-email-lizf@kernel.org>
2015-06-16 8:36 ` [PATCH 3.4 165/172] config: Enable NEED_DMA_MAP_STATE by default when SWIOTLB is selected lizf
@ 2015-06-16 15:13 ` Ian Campbell
[not found] ` <1434467619.13744.221.camel@citrix.com>
2 siblings, 0 replies; 4+ messages in thread
From: Ian Campbell @ 2015-06-16 15:13 UTC (permalink / raw
To: lizf; +Cc: Zefan Li, linux, linux-kernel, stable, xen-devel
On Tue, 2015-06-16 at 16:33 +0800, lizf@kernel.org wrote:
> From: Zefan Li <lizefan@huawei.com>
>
> This is the start of the stable review cycle for the 3.4.108 release.
> There are 172 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu Jun 18 08:30:58 UTC 2015.
> Anything received after that time might be too late.
Would it be possible to also include 31a418986a58 "xen: netback: read
hotplug script once at start of day." which has started trickling into
other stable branches already, please.
If not now then for 109.
Thanks,
Ian.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 3.4 000/172] 3.4.108-rc1 review
[not found] ` <1434467619.13744.221.camel@citrix.com>
@ 2015-06-18 3:19 ` Zefan Li
[not found] ` <558238AA.2090107@huawei.com>
1 sibling, 0 replies; 4+ messages in thread
From: Zefan Li @ 2015-06-18 3:19 UTC (permalink / raw
To: Ian Campbell; +Cc: lizf, xen-devel, linux-kernel, stable, linux
On 2015/6/16 23:13, Ian Campbell wrote:
> On Tue, 2015-06-16 at 16:33 +0800, lizf@kernel.org wrote:
>> From: Zefan Li <lizefan@huawei.com>
>>
>> This is the start of the stable review cycle for the 3.4.108 release.
>> There are 172 patches in this series, all will be posted as a response
>> to this one. If anyone has any issues with these being applied, please
>> let me know.
>>
>> Responses should be made by Thu Jun 18 08:30:58 UTC 2015.
>> Anything received after that time might be too late.
>
> Would it be possible to also include 31a418986a58 "xen: netback: read
> hotplug script once at start of day." which has started trickling into
> other stable branches already, please.
>
> If not now then for 109.
>
Queued up for 3.4.108. :)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 3.4 000/172] 3.4.108-rc1 review
[not found] ` <558238AA.2090107@huawei.com>
@ 2015-06-18 8:34 ` Ian Campbell
0 siblings, 0 replies; 4+ messages in thread
From: Ian Campbell @ 2015-06-18 8:34 UTC (permalink / raw
To: Zefan Li; +Cc: lizf, xen-devel, linux-kernel, stable, linux
On Thu, 2015-06-18 at 11:19 +0800, Zefan Li wrote:
> On 2015/6/16 23:13, Ian Campbell wrote:
> > On Tue, 2015-06-16 at 16:33 +0800, lizf@kernel.org wrote:
> >> From: Zefan Li <lizefan@huawei.com>
> >>
> >> This is the start of the stable review cycle for the 3.4.108 release.
> >> There are 172 patches in this series, all will be posted as a response
> >> to this one. If anyone has any issues with these being applied, please
> >> let me know.
> >>
> >> Responses should be made by Thu Jun 18 08:30:58 UTC 2015.
> >> Anything received after that time might be too late.
> >
> > Would it be possible to also include 31a418986a58 "xen: netback: read
> > hotplug script once at start of day." which has started trickling into
> > other stable branches already, please.
> >
> > If not now then for 109.
> >
>
> Queued up for 3.4.108. :)
Smashing, thank you.
Ian.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-06-18 8:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1434443587-4599-1-git-send-email-lizf@kernel.org>
2015-06-16 8:36 ` [PATCH 3.4 165/172] config: Enable NEED_DMA_MAP_STATE by default when SWIOTLB is selected lizf
2015-06-16 15:13 ` [PATCH 3.4 000/172] 3.4.108-rc1 review Ian Campbell
[not found] ` <1434467619.13744.221.camel@citrix.com>
2015-06-18 3:19 ` Zefan Li
[not found] ` <558238AA.2090107@huawei.com>
2015-06-18 8:34 ` Ian Campbell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).