* [PATCH OSSTEST] mg-list-all-branches: Sort branches according to any embedded version
@ 2015-07-13 8:13 Ian Campbell
2015-07-16 16:17 ` Ian Jackson
0 siblings, 1 reply; 4+ messages in thread
From: Ian Campbell @ 2015-07-13 8:13 UTC (permalink / raw
To: ian.jackson; +Cc: Ian Campbell, xen-devel
Many of our branches include a version number, this change results in
e.g. linux-3.0 < linux-3.4 < linux-3.10 rather than linux-3.0 <
linux-3.10 < linux-3.4, which is more natural for uses such as
./mg-all-branch-statuses.
Requires Sort::Versions (Debian package libsort-versions-perl).
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
mg-list-all-branches | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/mg-list-all-branches b/mg-list-all-branches
index c968a99..1549f81 100755
--- a/mg-list-all-branches
+++ b/mg-list-all-branches
@@ -3,6 +3,7 @@
# mentioned in cr-daily-branch or crontab
use strict;
+use Sort::Versions;
our %branches;
@@ -15,4 +16,4 @@ foreach my $f (qw(cr-for-branches crontab)) {
close C or die $!;
}
-print $_,"\n" or die $! foreach sort keys %branches;
+print $_,"\n" or die $! foreach sort { versioncmp($a, $b) } keys %branches;
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH OSSTEST] mg-list-all-branches: Sort branches according to any embedded version
2015-07-13 8:13 [PATCH OSSTEST] mg-list-all-branches: Sort branches according to any embedded version Ian Campbell
@ 2015-07-16 16:17 ` Ian Jackson
2015-07-16 16:24 ` Ian Campbell
0 siblings, 1 reply; 4+ messages in thread
From: Ian Jackson @ 2015-07-16 16:17 UTC (permalink / raw
To: Ian Campbell; +Cc: xen-devel
Ian Campbell writes ("[PATCH OSSTEST] mg-list-all-branches: Sort branches according to any embedded version"):
> Many of our branches include a version number, this change results in
> e.g. linux-3.0 < linux-3.4 < linux-3.10 rather than linux-3.0 <
> linux-3.10 < linux-3.4, which is more natural for uses such as
> ./mg-all-branch-statuses.
>
> Requires Sort::Versions (Debian package libsort-versions-perl).
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
This poses no risk to the production system, so I will push it now. I
have installed the perl module on the Xen Project colo and Citrix
Cambridge instances.
Ian.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH OSSTEST] mg-list-all-branches: Sort branches according to any embedded version
2015-07-16 16:17 ` Ian Jackson
@ 2015-07-16 16:24 ` Ian Campbell
2015-07-16 16:27 ` Ian Jackson
0 siblings, 1 reply; 4+ messages in thread
From: Ian Campbell @ 2015-07-16 16:24 UTC (permalink / raw
To: Ian Jackson; +Cc: xen-devel
On Thu, 2015-07-16 at 17:17 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST] mg-list-all-branches: Sort branches according to any embedded version"):
> > Many of our branches include a version number, this change results in
> > e.g. linux-3.0 < linux-3.4 < linux-3.10 rather than linux-3.0 <
> > linux-3.10 < linux-3.4, which is more natural for uses such as
> > ./mg-all-branch-statuses.
> >
> > Requires Sort::Versions (Debian package libsort-versions-perl).
> >
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
>
> This poses no risk to the production system, so I will push it now.
Thanks, you can ignore my other mail now ;-) (the one in response to
"I'm looking through my INBOX")
> I
> have installed the perl module on the Xen Project colo and Citrix
> Cambridge instances.
Thanks, I nearly forgot...
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH OSSTEST] mg-list-all-branches: Sort branches according to any embedded version
2015-07-16 16:24 ` Ian Campbell
@ 2015-07-16 16:27 ` Ian Jackson
0 siblings, 0 replies; 4+ messages in thread
From: Ian Jackson @ 2015-07-16 16:27 UTC (permalink / raw
To: Ian Campbell; +Cc: xen-devel
Ian Campbell writes ("Re: [PATCH OSSTEST] mg-list-all-branches: Sort branches according to any embedded version"):
> On Thu, 2015-07-16 at 17:17 +0100, Ian Jackson wrote:
> > I
> > have installed the perl module on the Xen Project colo and Citrix
> > Cambridge instances.
>
> Thanks, I nearly forgot...
But you wrote it in the commit message and for once I didn't overlook
it.
Ian.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-07-16 16:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-13 8:13 [PATCH OSSTEST] mg-list-all-branches: Sort branches according to any embedded version Ian Campbell
2015-07-16 16:17 ` Ian Jackson
2015-07-16 16:24 ` Ian Campbell
2015-07-16 16:27 ` Ian Jackson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).