From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "Roger Pau Monné" <roger.pau@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 2/4] x86/xstate: Rework xstate_ctxt_size() as xstate_uncompressed_size()
Date: Thu, 2 May 2024 14:19:29 +0200 [thread overview]
Message-ID: <741d4bef-8711-4802-91ad-8a6b4459da61@suse.com> (raw)
In-Reply-To: <20240429182823.1130436-3-andrew.cooper3@citrix.com>
On 29.04.2024 20:28, Andrew Cooper wrote:
> @@ -567,16 +567,51 @@ static unsigned int hw_uncompressed_size(uint64_t xcr0)
> return size;
> }
>
> -/* Fastpath for common xstate size requests, avoiding reloads of xcr0. */
> -unsigned int xstate_ctxt_size(u64 xcr0)
> +unsigned int xstate_uncompressed_size(uint64_t xcr0)
> {
> + unsigned int size = XSTATE_AREA_MIN_SIZE, i;
> +
> if ( xcr0 == xfeature_mask )
> return xsave_cntxt_size;
>
> if ( xcr0 == 0 ) /* TODO: clean up paths passing 0 in here. */
> return 0;
>
> - return hw_uncompressed_size(xcr0);
> + if ( xcr0 <= (X86_XCR0_SSE | X86_XCR0_FP) )
This is open-coded XSTATE_FP_SSE, which I wouldn't mind if ...
> + return size;
> +
> + /*
> + * For the non-legacy states, search all activate states and find the
> + * maximum offset+size. Some states (e.g. LWP, APX_F) are out-of-order
> + * with respect their index.
> + */
> + xcr0 &= ~XSTATE_FP_SSE;
... you didn't use that macro here (and once further down). IOW please
be consistent, no matter which way round.
> + for_each_set_bit ( i, &xcr0, 63 )
> + {
> + unsigned int s;
> +
> + ASSERT(xstate_offsets[i] && xstate_sizes[i]);
> +
> + s = xstate_offsets[i] && xstate_sizes[i];
You mean + here, don't you? Then:
Reviewed-by: Jan Beulich <jbeulich@suse.com>
I'm also inclined to suggest making this the initializer of s.
Jan
next prev parent reply other threads:[~2024-05-02 12:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 18:28 [PATCH v2 0/4] x86/xstate: Fixes to size calculations Andrew Cooper
2024-04-29 18:28 ` [PATCH v2 1/4] x86/hvm: Defer the size calculation in hvm_save_cpu_xsave_states() Andrew Cooper
2024-05-02 12:08 ` Jan Beulich
2024-04-29 18:28 ` [PATCH v2 2/4] x86/xstate: Rework xstate_ctxt_size() as xstate_uncompressed_size() Andrew Cooper
2024-05-02 12:19 ` Jan Beulich [this message]
2024-05-02 13:17 ` Andrew Cooper
2024-04-29 18:28 ` [PATCH v2 3/4] x86/cpu-policy: Simplify recalculate_xstate() Andrew Cooper
2024-05-02 12:39 ` Jan Beulich
2024-05-02 13:24 ` Andrew Cooper
2024-05-02 14:33 ` Jan Beulich
2024-04-29 18:28 ` [PATCH v2 4/4] x86/cpuid: Fix handling of xsave dynamic leaves Andrew Cooper
2024-05-02 13:04 ` Jan Beulich
2024-05-02 14:32 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=741d4bef-8711-4802-91ad-8a6b4459da61@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).