From: Fouad Hilly <fouad.hilly@cloud.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Anthony PERARD <anthony@xenproject.org>,
Juergen Gross <jgross@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3 5/5] Add --force option to xen-ucode to override microcode version check
Date: Thu, 9 May 2024 15:31:06 +0100 [thread overview]
Message-ID: <CAJKAvHZfOVnNR4uv5d8X53o=m3YPCQSPSU0UaYhnq6dKPgbDuQ@mail.gmail.com> (raw)
In-Reply-To: <8b433feb-467c-4569-9426-cc245fc9da50@suse.com>
On Mon, May 6, 2024 at 10:39 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 30.04.2024 14:47, Fouad Hilly wrote:
> > @@ -21,10 +23,11 @@ static const char amd_id[] = "AuthenticAMD";
> > static void usage(const char *name)
> > {
> > printf("%s: Xen microcode updating tool\n"
> > - "Usage: %s [<microcode file> | Options]\n"
> > + "Usage: %s [microcode file] [options]\n"
> > "options:\n"
> > " -h, --help display this help and exit\n"
> > - " -s, --show-cpu-info show CPU information and exit\n",
> > + " -s, --show-cpu-info show CPU information and exit\n"
> > + " -f, --force force to skip micorocde version check\n",
>
> Besides (nit) the typo, isn't "version check" too broad here? Elsewhere in the
> series you mention Intel's "min_rev" addition. _That_ kind of version check
> probably shouldn't be permitted to skip? In which case maybe better "certain
> version checking" or some such?
I will remove "min_rev" mention from this patch series. The main
reason for this change is to allow developers to downgrade microcode.
>
> Jan
prev parent reply other threads:[~2024-05-09 14:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 12:47 [PATCH v3 0/5] x86/xen-ucode: Introduce --force option Fouad Hilly
2024-04-30 12:47 ` [PATCH v3 1/5] x86: Update x86 low level version check of microcode Fouad Hilly
2024-05-06 8:45 ` Jan Beulich
2024-05-09 14:33 ` Fouad Hilly
2024-04-30 12:47 ` [PATCH v3 2/5] x86: Refactor microcode_update() hypercall with flags Fouad Hilly
2024-05-06 9:14 ` Jan Beulich
2024-05-09 14:15 ` Fouad Hilly
2024-04-30 12:47 ` [PATCH v3 3/5] x86: Add usage() to print out usage message Fouad Hilly
2024-05-06 8:20 ` Jan Beulich
2024-05-09 13:59 ` Fouad Hilly
2024-04-30 12:47 ` [PATCH v3 4/5] x86: Use getopt to handle command line args Fouad Hilly
2024-05-06 8:21 ` Jan Beulich
2024-05-09 13:59 ` Fouad Hilly
2024-04-30 12:47 ` [PATCH v3 5/5] Add --force option to xen-ucode to override microcode version check Fouad Hilly
2024-05-06 9:39 ` Jan Beulich
2024-05-09 14:31 ` Fouad Hilly [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJKAvHZfOVnNR4uv5d8X53o=m3YPCQSPSU0UaYhnq6dKPgbDuQ@mail.gmail.com' \
--to=fouad.hilly@cloud.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony@xenproject.org \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).