From: Stefano Stabellini <sstabellini@kernel.org>
To: Federico Serafini <federico.serafini@bugseng.com>
Cc: xen-devel@lists.xenproject.org, consulting@bugseng.com,
Simone Ballarin <simone.ballarin@bugseng.com>,
Doug Goldstein <cardoe@cardoe.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>
Subject: Re: [XEN PATCH 2/2] automation/eclair: add deviation for Rule 16.4
Date: Fri, 3 May 2024 16:09:58 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2405031609400.1151289@ubuntu-linux-20-04-desktop> (raw)
In-Reply-To: <d4670fa5bd7e33a915d5642cb78eb2eb33988819.1714727807.git.federico.serafini@bugseng.com>
On Fri, 3 May 2024, Federico Serafini wrote:
> MISRA C:2012 Rule 16.4 states that "Every switch statement shall have a
> default label".
> Update ECLAIR configuration to take into account the deviations
> agreed during MISRA meetings.
>
> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> automation/eclair_analysis/ECLAIR/deviations.ecl | 8 ++++++++
> docs/misra/deviations.rst | 13 +++++++++++++
> 2 files changed, 21 insertions(+)
>
> diff --git a/automation/eclair_analysis/ECLAIR/deviations.ecl b/automation/eclair_analysis/ECLAIR/deviations.ecl
> index d21f112a9b..f09ad71acf 100644
> --- a/automation/eclair_analysis/ECLAIR/deviations.ecl
> +++ b/automation/eclair_analysis/ECLAIR/deviations.ecl
> @@ -384,6 +384,14 @@ explicit comment indicating the fallthrough intention is present."
> -config=MC3R1.R16.3,reports+={safe, "any_area(end_loc(any_exp(text(^(?s).*/\\* [fF]all ?through.? \\*/.*$,0..1))))"}
> -doc_end
>
> +-doc_begin="Switch statements having a controlling expression of enum type deliberately do not have a default case: gcc -Wall enables -Wswitch which warns (and breaks the build as we use -Werror) if one of the enum labels is missing from the switch."
> +-config=MC3R1.R16.4,reports+={deliberate,'any_area(kind(context)&&^.* has no `default.*$&&stmt(node(switch_stmt)&&child(cond,skip(__non_syntactic_paren_stmts,type(canonical(enum_underlying_type(any())))))))'}
> +-doc_end
> +
> +-doc_begin="A switch statement with a single switch clause and no default label may be used in place of an equivalent if statement if it is considered to improve readability."
> +-config=MC3R1.R16.4,switch_clauses+={deliberate,"switch(1)&&default(0)"}
> +-doc_end
> +
> -doc_begin="A switch statement with a single switch clause and no default label may be used in place of an equivalent if statement if it is considered to improve readability."
> -config=MC3R1.R16.6,switch_clauses+={deliberate, "default(0)"}
> -doc_end
> diff --git a/docs/misra/deviations.rst b/docs/misra/deviations.rst
> index ed0c1e8ed0..39cc321a27 100644
> --- a/docs/misra/deviations.rst
> +++ b/docs/misra/deviations.rst
> @@ -334,6 +334,19 @@ Deviations related to MISRA C:2012 Rules:
> - /\* Fallthrough \*/
> - /\* Fallthrough. \*/
>
> + * - R16.4
> + - Switch statements having a controlling expression of enum type
> + deliberately do not have a default case: gcc -Wall enables -Wswitch
> + which warns (and breaks the build as we use -Werror) if one of the enum
> + labels is missing from the switch.
> + - Tagged as `deliberate` for ECLAIR.
> +
> + * - R16.4
> + - A switch statement with a single switch clause and no default label may
> + be used in place of an equivalent if statement if it is considered to
> + improve readability.
> + - Tagged as `deliberate` for ECLAIR.
> +
> * - R16.6
> - A switch statement with a single switch clause and no default label may
> be used in place of an equivalent if statement if it is considered to
> --
> 2.34.1
>
prev parent reply other threads:[~2024-05-03 23:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 9:58 [XEN PATCH 0/2] misra: deviations of Rule 16.4 Federico Serafini
2024-05-03 9:58 ` [XEN PATCH 1/2] docs/misra: add Terms & Definitions section to rules.rst Federico Serafini
2024-05-03 23:08 ` Stefano Stabellini
2024-05-03 9:58 ` [XEN PATCH 2/2] automation/eclair: add deviation for Rule 16.4 Federico Serafini
2024-05-03 23:09 ` Stefano Stabellini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2405031609400.1151289@ubuntu-linux-20-04-desktop \
--to=sstabellini@kernel.org \
--cc=andrew.cooper3@citrix.com \
--cc=cardoe@cardoe.com \
--cc=consulting@bugseng.com \
--cc=federico.serafini@bugseng.com \
--cc=george.dunlap@citrix.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=simone.ballarin@bugseng.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).