Xen-Devel Archive mirror
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: Fonyuy-Asheri Caleb <fonyuy-asheri.caleb@inria.fr>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
	"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: file xen/include/xen/lib/x86/cpu-policy.h: Meaning of CPUID constants
Date: Mon, 6 May 2024 10:47:39 +0200	[thread overview]
Message-ID: <b892301a-0f45-4bc3-a117-b96672cc36a6@suse.com> (raw)
In-Reply-To: <1049993614.4894172.1714985159910.JavaMail.zimbra@inria.fr>

On 06.05.2024 10:45, Fonyuy-Asheri Caleb wrote:
>> From: "Roger Pau Monné" <roger.pau@citrix.com>
>> Sent: Monday, May 6, 2024 10:34:20 AM
> 
>> For basic leaves (0x000000xx) we support up to leaf 0xd (XSTATE).  It
>> doesn't mean there are no further leaves behind it, but we likely
>> still have no use for them, and hence they are not part of the policy.
>> The cpu-policy is used to store a (cpuid) policy object for guests,
>> so if the information exposed in those leaves are related to features
>> that are never exposed to guests is makes no sense to have space for
>> them.
> 
> So if I understand you well, you mean before extending this, we need to perform a study on the 
> leaves to confirm how useful they are to the guests depending on the cpu information they carry. 

It's not only question of usefulness, but of correctness. We can't blindly
expose leaves.

Jan


      reply	other threads:[~2024-05-06  8:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-06  7:46 file xen/include/xen/lib/x86/cpu-policy.h: Meaning of CPUID constants Fonyuy-Asheri Caleb
2024-05-06  8:13 ` Jan Beulich
2024-05-06  8:34 ` Roger Pau Monné
2024-05-06  8:45   ` Fonyuy-Asheri Caleb
2024-05-06  8:47     ` Jan Beulich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b892301a-0f45-4bc3-a117-b96672cc36a6@suse.com \
    --to=jbeulich@suse.com \
    --cc=fonyuy-asheri.caleb@inria.fr \
    --cc=roger.pau@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).