From: Julien Grall <julien@xen.org>
To: Michal Orzel <michal.orzel@amd.com>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Jan Beulich <jbeulich@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH] public: xen: Define missing guest handle for int32_t
Date: Wed, 17 Apr 2024 15:17:09 +0100 [thread overview]
Message-ID: <be95f6be-0404-4c43-926f-d011782a02db@xen.org> (raw)
In-Reply-To: <20240417121442.56178-1-michal.orzel@amd.com>
Hi Michal,
On 17/04/2024 13:14, Michal Orzel wrote:
> Commit afab29d0882f ("public: s/int/int32_t") replaced int with int32_t
> in XEN_GUEST_HANDLE() in memory.h but there is no guest handle defined
> for it. This results in a build failure. Example on Arm:
>
> ./include/public/arch-arm.h:205:41: error: unknown type name ‘__guest_handle_64_int32_t’
> 205 | #define __XEN_GUEST_HANDLE(name) __guest_handle_64_ ## name
> | ^~~~~~~~~~~~~~~~~~
> ./include/public/arch-arm.h:206:41: note: in expansion of macro ‘__XEN_GUEST_HANDLE’
> 206 | #define XEN_GUEST_HANDLE(name) __XEN_GUEST_HANDLE(name)
> | ^~~~~~~~~~~~~~~~~~
> ./include/public/memory.h:277:5: note: in expansion of macro ‘XEN_GUEST_HANDLE’
> 277 | XEN_GUEST_HANDLE(int32_t) errs;
>
> Fix it. Also, drop guest handle definition for int given no further use.
>
> Fixes: afab29d0882f ("public: s/int/int32_t")
> Signed-off-by: Michal Orzel <michal.orzel@amd.com>
So it turned out that I committed v1 from Stefano. I was meant to commit
the patch at all, but I think I started with a dirty staging :(. Sorry
for that.
I have reverted Stefano's commit for now so we can take the correct patch.
Now, from my understanding, Andrew suggested on Matrix that this
solution may actually be a good way to handle GUEST_HANLDEs (they were
removed in v2). Maybe this can be folded in Stefano's patch?
Cheers,
--
Julien Grall
next prev parent reply other threads:[~2024-04-17 14:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 12:14 [PATCH] public: xen: Define missing guest handle for int32_t Michal Orzel
2024-04-17 12:52 ` Luca Fancellu
2024-04-17 14:17 ` Julien Grall [this message]
2024-04-17 18:49 ` Stefano Stabellini
2024-04-22 15:10 ` Julien Grall
2024-04-25 22:39 ` Stefano Stabellini
2024-04-26 6:06 ` Jan Beulich
2024-04-26 21:28 ` Stefano Stabellini
2024-04-18 7:26 ` Jan Beulich
2024-04-18 7:29 ` Michal Orzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be95f6be-0404-4c43-926f-d011782a02db@xen.org \
--to=julien@xen.org \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=jbeulich@suse.com \
--cc=michal.orzel@amd.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).