From: Philippe Gerum <rpm@xenomai.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Xenomai <xenomai@lists.linux.dev>
Subject: Re: [libevl][PATCH] build: Reject building for i386
Date: Wed, 03 Jan 2024 10:07:40 +0100 [thread overview]
Message-ID: <87bka2wzrx.fsf@xenomai.org> (raw)
In-Reply-To: <ca68187b-b9e8-4200-9090-81f768b1b5cb@siemens.com>
Jan Kiszka <jan.kiszka@siemens.com> writes:
> On 17.12.23 17:22, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> This architecture is not supported but we were silently converting it
>> into 64-bit x86.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>> meson.build | 7 +++++--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/meson.build b/meson.build
>> index bbde902..fdb2e55 100644
>> --- a/meson.build
>> +++ b/meson.build
>> @@ -46,12 +46,15 @@ pthread_dep = dependency('threads')
>>
>> # Do some architecture name remapping
>> libevl_arch = host_machine.cpu_family()
>> +if libevl_arch == 'x86'
>> + error('i386 not supported')
>> +endif
>> if libevl_arch == 'x86_64'
>> - libevl_arch = 'x86'
>> + libevl_arch = 'x86'
>> endif
>>
>> if libevl_arch == 'aarch64'
>> - libevl_arch = 'arm64'
>> + libevl_arch = 'arm64'
>> endif
>>
>> post_install = find_program('post-install.sh',
>
> As you are merging already, don't forgot this one as well. Minor but
> possibly still helpful for newbies.
>
Merged, thanks.
--
Philippe.
prev parent reply other threads:[~2024-01-03 9:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-17 16:22 [libevl][PATCH] build: Reject building for i386 Jan Kiszka
2024-01-02 16:56 ` Jan Kiszka
2024-01-03 9:07 ` Philippe Gerum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bka2wzrx.fsf@xenomai.org \
--to=rpm@xenomai.org \
--cc=jan.kiszka@siemens.com \
--cc=xenomai@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).