From: "Jiang, Yi" <yi.jiang@siemens.com>
To: "Kiszka, Jan" <jan.kiszka@siemens.com>,
"xenomai@lists.linux.dev" <xenomai@lists.linux.dev>
Subject: Re: [PATCH 3/3] rpi4: add building options, remove old kernel and Xenomai versions in kas menu.
Date: Wed, 22 May 2024 12:37:08 +0000 [thread overview]
Message-ID: <a25224be741df1e09945d05a8fca773905ae8843.camel@siemens.com> (raw)
In-Reply-To: <7a404b5e-77b3-4f95-a088-f4a36e97ce03@siemens.com>
On Tue, 2024-05-21 at 16:54 +0200, Jan Kiszka wrote:
> On 21.05.24 15:48, Yi Jiang wrote:
> > The following kernel versions are removed from kas menu:
> >
> > - Xenomai 3, Head of stable/v3.1.x branch.
> >
> > The following Xenomai versions are removed from kas menu:
> >
> > - Xenomai 3, Latest 4.19-cip I-pipe release;
> > - Xenomai 3, Head of 4.19-cip I-pipe branch;
> > - Xenomai 3, Latest 5.4 I-pipe release;
> > - Xenomai 3, Head of 5.4 I-pipe branch.
>
> This message is confusing. It reads like those configurations are
> removed in general. But what you are rather doing is to prevent that
> unsupported combinations can be selected in the menu. Please reword.
>
> Jan
Thanks for the suggestion. I will improve the wording in the next
version of the patch.
>
> >
> > Signed-off-by: Yi Jiang <yi.jiang@siemens.com>
> > ---
> > Kconfig | 14 ++++++++++----
> > 1 file changed, 10 insertions(+), 4 deletions(-)
> >
> > diff --git a/Kconfig b/Kconfig
> > index 669ea65..13699bf 100644
> > --- a/Kconfig
> > +++ b/Kconfig
> > @@ -45,6 +45,10 @@ config TARGET_HIKEY
> > bool "LeMaker HiKey"
> > select ARCH_ARM64
> >
> > +config TARGET_RPI4
> > + bool "Raspberry Pi 4"
> > + select ARCH_ARM64
> > +
> > endchoice
> >
> > config KAS_INCLUDE_TARGET
> > @@ -55,6 +59,7 @@ config KAS_INCLUDE_TARGET
> > default "board-beagle-bone-black.yml" if TARGET_BBB
> > default "board-qemu-arm64.yml" if TARGET_QEMU_ARM64
> > default "board-hikey.yml" if TARGET_HIKEY
> > + default "board-rpi4.yml" if TARGET_RPI4
> >
> > choice
> > prompt "Xenomai version"
> > @@ -85,6 +90,7 @@ config XENOMAI_3_2
> >
> > config XENOMAI_3_1_LATEST
> > bool "Head of stable/v3.1.x branch"
> > + depends on !TARGET_RPI4
> >
> > config XENOMAI_3_0_LATEST
> > bool "Head of stable/v3.0.x branch"
> > @@ -141,19 +147,19 @@ config KERNEL_5_10
> >
> > config KERNEL_5_4_LATEST
> > bool "Head of 5.4 I-pipe branch"
> > - depends on XENOMAI_3_2_LATEST || XENOMAI_3_2 ||
> > XENOMAI_3_1_LATEST || XENOMAI_3_1
> > + depends on !TARGET_RPI4 && (XENOMAI_3_2_LATEST ||
> > XENOMAI_3_2 || XENOMAI_3_1_LATEST || XENOMAI_3_1)
> >
> > config KERNEL_5_4
> > bool "Latest 5.4 I-pipe release"
> > - depends on XENOMAI_3_2_LATEST || XENOMAI_3_2 ||
> > XENOMAI_3_1_LATEST || XENOMAI_3_1
> > + depends on !TARGET_RPI4 && (XENOMAI_3_2_LATEST ||
> > XENOMAI_3_2 || XENOMAI_3_1_LATEST || XENOMAI_3_1)
> >
> > config KERNEL_4_19_LATEST
> > bool "Head of 4.19-cip I-pipe branch"
> > - depends on XENOMAI_3_2_LATEST || XENOMAI_3_2 ||
> > XENOMAI_3_1_LATEST || XENOMAI_3_1
> > + depends on !TARGET_RPI4 && (XENOMAI_3_2_LATEST ||
> > XENOMAI_3_2 || XENOMAI_3_1_LATEST || XENOMAI_3_1)
> >
> > config KERNEL_4_19
> > bool "Latest 4.19-cip I-pipe release"
> > - depends on XENOMAI_3_2_LATEST || XENOMAI_3_2 ||
> > XENOMAI_3_1_LATEST || XENOMAI_3_1
> > + depends on !TARGET_RPI4 && (XENOMAI_3_2_LATEST ||
> > XENOMAI_3_2 || XENOMAI_3_1_LATEST || XENOMAI_3_1)
> >
> > config KERNEL_4_4_LATEST
> > bool "Head of 4.4-cip I-pipe branch"
>
--
Yi Jiang
Siemens AG
www.siemens.com
prev parent reply other threads:[~2024-05-22 12:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-21 13:48 [PATCH 1/3] rpi-firmware: Add recipe for building version 20230405 Yi Jiang
2024-05-21 13:48 ` [PATCH 2/3] rpi4: Add rpi4 (Raspberry Pi 4) as target platform Yi Jiang
2024-05-21 14:52 ` Jan Kiszka
2024-05-21 15:57 ` Florian Bezdeka
2024-05-22 12:35 ` Jiang, Yi
2024-05-23 8:46 ` Florian Bezdeka
2024-05-23 14:16 ` Jan Kiszka
2024-05-23 14:19 ` Florian Bezdeka
2024-05-21 13:48 ` [PATCH 3/3] rpi4: add building options, remove old kernel and Xenomai versions in kas menu Yi Jiang
2024-05-21 14:54 ` Jan Kiszka
2024-05-22 12:37 ` Jiang, Yi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a25224be741df1e09945d05a8fca773905ae8843.camel@siemens.com \
--to=yi.jiang@siemens.com \
--cc=jan.kiszka@siemens.com \
--cc=xenomai@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).