From: Jan Kiszka <jan.kiszka@siemens.com>
To: Richard Weinberger <richard.weinberger@gmail.com>
Cc: Richard Weinberger <richard@nod.at>, xenomai@lists.linux.dev
Subject: Re: [PATCH 2/2] prepare-kernel.sh: Warn when result can be defective
Date: Mon, 8 Apr 2024 22:53:39 +0200 [thread overview]
Message-ID: <d687e7f4-3002-4086-9cf5-8f37daa935d9@siemens.com> (raw)
In-Reply-To: <CAFLxGvxTQ1JB7XmA=4pxeyQo7t+fV8ueFp5QiWxyKiZW57jr7w@mail.gmail.com>
On 08.04.24 21:46, Richard Weinberger wrote:
> On Mon, Apr 8, 2024 at 9:42 PM Jan Kiszka <jan.kiszka@siemens.com> wrote:
>>> It triggers, e.g.
>>> rw@foxxylove:~/xenomai (prepare_cleanup)> echo zonk >
>>> ~/linux/kernel/xenomai/lock.c
>>> rw@foxxylove:~/xenomai (prepare_cleanup)> ./scripts/prepare-kernel.sh
>>> --linux=/home/rw/linux --arch=arm64
>>> prepare-kernel.sh: warning: kernel/xenomai/lock.c already present in
>>> Linux kernel tree, resulting source tree might be inconsistent!
>>>
>>> Only when using the --forcelink flag existing files will be overwritten.
>>>
>>
>> Nope, the file is overwritten without your patch. Now it is left
>> untouched behind, and the preparation is indeed broken. That's not
>> really an improvement...
>
> Dang, you're right. Just tried myself on the master branch.
> What is the purpose of --forcelink then?
That will likely remain a mystery. It was once introduced via
bc2959c7241f411b15396fa6811fb57213c998ef, but that was under-documented.
With 7098866e087e092701034e0b950ef5eb4ea19a0a, I suspect it lost its
relevance.
Jan
--
Siemens AG, Technology
Linux Expert Center
next prev parent reply other threads:[~2024-04-08 20:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 21:48 [PATCH 1/2] prepare-kernel.sh: Remove patch_ed function Richard Weinberger
2024-04-03 21:48 ` [PATCH 2/2] prepare-kernel.sh: Warn when result can be defective Richard Weinberger
2024-04-08 16:10 ` Jan Kiszka
2024-04-08 19:34 ` Richard Weinberger
2024-04-08 19:42 ` Jan Kiszka
2024-04-08 19:46 ` Richard Weinberger
2024-04-08 20:53 ` Jan Kiszka [this message]
2024-04-08 16:09 ` [PATCH 1/2] prepare-kernel.sh: Remove patch_ed function Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d687e7f4-3002-4086-9cf5-8f37daa935d9@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=richard.weinberger@gmail.com \
--cc=richard@nod.at \
--cc=xenomai@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).