From: Rahul T R <r-ravikumar@ti.com>
To: <meta-arago@lists.yoctoproject.org>
Cc: <p-mantena@ti.com>, <devarsht@ti.com>,
Ryan Eatmon <reatmon@ti.com>, <denys@ti.com>,
<r-ravikumar@ti.com>
Subject: [meta-arago][master/kirkstone][PATCH v2] gstreamer1.0-plugins-good: wave5-codec: Set max buffers same as min buffers
Date: Wed, 18 Oct 2023 14:49:46 +0530 [thread overview]
Message-ID: <20231018091946.754458-1-r-ravikumar@ti.com> (raw)
v4l2src plugin queues same external buffer with different v4l2 buffer
with different index. This workaround was implemented as a workaround
for this. Workaround needs all buffers to be allocated during the init
phase, if new buffers are allocated post stream start it fails. Avoid
such issues by enforcing max buffers same as min buffers
Signed-off-by: Rahul T R <r-ravikumar@ti.com>
Reviewed-by: Devarsh Thakkar <devarsht@ti.com>
Reviewed-by: Prasanth Babu Mantena <p-mantena@ti.com>
---
Notes:
v2:
Updated commit message as per the comments
Added the reviewed bys
.../0001-v4l2-Changes-for-DMA-Buf-import-j721s2.patch | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good/0001-v4l2-Changes-for-DMA-Buf-import-j721s2.patch b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good/0001-v4l2-Changes-for-DMA-Buf-import-j721s2.patch
index a1471661..bf73e257 100644
--- a/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good/0001-v4l2-Changes-for-DMA-Buf-import-j721s2.patch
+++ b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good/0001-v4l2-Changes-for-DMA-Buf-import-j721s2.patch
@@ -14,9 +14,9 @@ Signed-off-by: Prasanth Babu Mantena <p-mantena@ti.com>
---
sys/v4l2/gstv4l2bufferpool.c | 17 ++++++++++++++---
sys/v4l2/gstv4l2bufferpool.h | 2 ++
- sys/v4l2/gstv4l2object.c | 15 ++++++++++++---
+ sys/v4l2/gstv4l2object.c | 16 +++++++++++++---
sys/v4l2/gstv4l2videodec.c | 20 ++++++++++++++------
- 4 files changed, 42 insertions(+), 12 deletions(-)
+ 4 files changed, 43 insertions(+), 12 deletions(-)
diff --git a/sys/v4l2/gstv4l2bufferpool.c b/sys/v4l2/gstv4l2bufferpool.c
index d85f036..e6a60dc 100644
@@ -86,7 +86,7 @@ index ee60540..eff1cf2 100644
own_min = MAX (own_min, GST_V4L2_MIN_BUFFERS (obj));
/* for the downstream pool, we keep what downstream wants, though ensure
-@@ -5049,8 +5053,13 @@ gst_v4l2_object_decide_allocation (GstV4l2Object * obj, GstQuery * query)
+@@ -5049,8 +5053,14 @@ gst_v4l2_object_decide_allocation (GstV4l2Object * obj, GstQuery * query)
min = MAX (min, GST_V4L2_MIN_BUFFERS (obj));
/* To import we need the other pool to hold at least own_min */
@@ -95,6 +95,7 @@ index ee60540..eff1cf2 100644
+ if (obj_pool == pool) {
+ if (0 == strcmp(obj->vcap.driver, "wave5-dec")) {
+ min = own_min;
++ max = min;
+ } else {
+ min += own_min;
+ }
--
2.34.1
next reply other threads:[~2023-10-18 9:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 9:19 Rahul T R [this message]
2023-10-18 14:35 ` [meta-arago][master/kirkstone][PATCH v2] gstreamer1.0-plugins-good: wave5-codec: Set max buffers same as min buffers Ryan Eatmon
2023-10-18 16:10 ` Rahul T R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231018091946.754458-1-r-ravikumar@ti.com \
--to=r-ravikumar@ti.com \
--cc=denys@ti.com \
--cc=devarsht@ti.com \
--cc=meta-arago@lists.yoctoproject.org \
--cc=p-mantena@ti.com \
--cc=reatmon@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).